Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

feat: rewrite the ObservableArray#9067

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Draft
farfromrefug wants to merge4 commits intoNativeScript:release/8.0.0
base:release/8.0.0
Choose a base branch
Loading
fromAkylas:observablearray_as_array

Conversation

farfromrefug
Copy link
Collaborator

@farfromrefugfarfromrefug commentedNov 25, 2020•
edited
Loading

This is now an ArrayLike object. Meaning we can dotest[4]= 4; and the array will be changed as well as a change event trigger.
It should work exactly as the current implementation.
One nice feature i would have liked which does not work yet is test instanceof Array.
If that was to work it means anObservableArray could be used anywhere and even passed to native methods (i think)

Forgot to say why i started this. This PR also brings all array like methods toObservableArray likefindIndex

CatchABus and vallemar reacted with thumbs up emojishirakaba reacted with rocket emoji
This is now an ArrayLike object. Meaning we can do `test[4]= 4;` and the array will be changed as well as a change event trigger.It should work exactly as the current implementation.One nice feature i would have liked which does not work yet is ` test instanceof Array`.If that was to work it means an `ObservableArray` could be used anywhere and even passed to native methods (i think)
@cla-botcla-botbot added the cla: yes labelNov 25, 2020
@farfromrefug
Copy link
CollaboratorAuthor

I found some issues with the WeakMap and that new implementation. That PR is not ready yet

@rigor789rigor789 marked this pull request as draftNovember 25, 2020 16:49
@NathanWalkerNathanWalker changed the base branch frommaster torelease/8.0.0January 29, 2021 20:25
@NathanWalkerNathanWalker added this to the8.4 milestoneAug 16, 2022
@NathanWalkerNathanWalker removed this from the8.4 milestoneNov 24, 2022
@NathanWalkerNathanWalker added this to the9.0 milestoneSep 2, 2023
@NathanWalker
Copy link
Contributor

@farfromrefug If this were ready soon we could likely include in 8.6, would just need to check any breaking changes to mention if so. Otherwise can target 9.0.

vallemar reacted with eyes emoji

@farfromrefug
Copy link
CollaboratorAuthor

@NathanWalker that one is really old. I will check if I use it in my fork. Doesn't Dimitris created one doing a better job?

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Projects
None yet
Milestone
9.0
Development

Successfully merging this pull request may close these issues.

2 participants
@farfromrefug@NathanWalker
[8]ページ先頭
©2009-2025 Movatter.jp