Movatterモバイル変換

Skip to content

NativeScript/NativeScriptPublic

NotificationsYou must be signed in to change notification settings
Fork1.7k
Star24.9k

fix(android): Setting String Value to Width And Height#10668

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open

db-r-hashimoto wants to merge2 commits intoNativeScript:main

base:main

Choose a base branch

fromdb-r-hashimoto:setting-string-value-width-height

Open

fix(android): Setting String Value to Width And Height#10668

db-r-hashimoto wants to merge2 commits intoNativeScript:mainfromdb-r-hashimoto:setting-string-value-width-height

Conversation

db-r-hashimoto

Copy link

db-r-hashimoto commentedJan 17, 2025

PR Checklist

The PR title follows our guidelines:https://github.com/NativeScript/NativeScript/blob/master/tools/notes/CONTRIBUTING.md#commit-messages.
There is an issue for the bug/feature this PR is for. To avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it.
You have signed theCLA.
All existing tests are passing:https://github.com/NativeScript/NativeScript/blob/master/tools/notes/DevelopmentWorkflow.md#running-unit-tests-application.
Tests for the changes are included -https://github.com/NativeScript/NativeScript/blob/master/tools/notes/WritingUnitTests.md.

What is the current behavior?

Currently, when a string value is assigned to the width or height property of ImageAssetOptions, an error occurs on Android. This issue prevents users from specifying these properties as strings, which can be problematic in scenarios where string-based dimensions are used.

What is the new behavior?

With this update, assigning a string value to the width or height property of ImageAssetOptions no longer results in an error on Android. The system now properly handles string-based dimensions, providing a more flexible and consistent experience for users.

Fixes/Implements/Closes#6289 .

@db-r-hashimoto

fix(android): Setting String Value to Width And Height

89ed02a

@CatchABus

Copy link

Contributor

CatchABus commentedJan 17, 2025•
edited
Loading

Let me point out that this looks like a requested feature.
Docs and TypeScript definitions (even if you use JavaScript) indicate that options will expect a type of number for dimensions so as long as you use it the right way, it will work.
Also, you can always make use of functions likeparseInt orparseFloat to pass the value as a number.
Regarding the error, core could also be strict and print a warning message about it instead to let users know that one has to use numeric values.

Few things to point out:

Some linting rules like single quotes aren't being followed.

@db-r-hashimoto

Copy link

Author

db-r-hashimoto commentedJan 17, 2025

@CatchABus Strings should use single quotes, as per the coding conventions outlinedhere. I'll fix it accordingly.

@db-r-hashimoto

fix to single quote

12ba676

@thearnabsaha

thearnabsaha mentioned this pull request

fix(android): handle width and height as strings in ImageAsset options#10728

Closed

3 tasks

@NathanWalker

NathanWalker force-pushed themain branch fromf234056 toa11ccd8Compare

June 26, 2025 18:37

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Labels

None yet

2 participants

@db-r-hashimoto

@CatchABus

[8]ページ先頭

©2009-2025 Movatter.jp