Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork1.7k
feat(core): Typography improvements#10648
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:main
Are you sure you want to change the base?
Uh oh!
There was an error while loading.Please reload this page.
Conversation
CatchABus commentedNov 18, 2024 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
EDITED: Added line-height percentage unit to make up for the lack of multiplier value. |
b35dca7
tof5f140f
Comparedf4824a
to666f261
CompareCatchABus commentedJan 25, 2025 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
All changes regarding letter-spacing unit have been removed from this PR. |
Uh oh!
There was an error while loading.Please reload this page.
PR Checklist
What is the current behavior?
Right now, typography is a bit inconsistent between the two platforms and MDN specs.
More specifically, line-height does not act as a height and its visual result is quite different than that of browser.
What is the new behavior?
BREAKING CHANGES: