Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork1.7k
perf(ios): gridlayout optimizations#10582
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:main
Are you sure you want to change the base?
perf(ios): gridlayout optimizations#10582
Uh oh!
There was an error while loading.Please reload this page.
Conversation
… readability and maintainability of iOS gridlayout.
Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors:sean kelly.
|
@SeanKelly369 possible to run some perf metrics before/after these changes? |
@NathanWalker what approach do you recommend I used to capture the performance? I could create a listview with items containing gridlayouts and calculate how much time it takes for the list to full render. |
That would be a good baseline to start with I think@SeanKelly369 Also a page with perhaps 100 Gridlayouts with 2 labels in them (copy/paste them out) and measure the time it takes to navigate to that page with 100 gridlayouts before/after (could bump that to 200, 300 or even 400 to see broader differences to get good idea). |
@NathanWalker When running this last year, the performance difference was in the nano-seconds. I'd say this isn't worth the risk merging for this reason. It's possibly dated by now as well. |
PR Checklist
What is the current behavior?
The behaviour of the gridlayout is okay, but the code can be optimised. I'm trying to get the ball rolling contributing to {N}
What is the new behavior?
Optimisation of the gridlayout code for iOS.
Fixes/Implements/Closes #[Issue Number].