Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

perf(ios): gridlayout optimizations#10582

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
SeanKelly369 wants to merge4 commits intoNativeScript:main
base:main
Choose a base branch
Loading
fromSeanKelly369:origin/feat/grid-layout-ios-optimisation

Conversation

SeanKelly369
Copy link

PR Checklist

What is the current behavior?

The behaviour of the gridlayout is okay, but the code can be optimised. I'm trying to get the ball rolling contributing to {N}

What is the new behavior?

Optimisation of the gridlayout code for iOS.

Fixes/Implements/Closes #[Issue Number].

@cla-botcla-bot
Copy link

cla-botbot commentedJul 11, 2024

Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors:sean kelly.
This is most likely caused by a git client misconfiguration; please make sure to:

  1. check if your git client is configured with an email to sign commitsgit config --list | grep email
  2. If not, set it up usinggit config --global user.email email@example.com
  3. Make sure that the git commit email is configured in your GitHub account settings, seehttps://github.com/settings/emails

@cla-botcla-botbot added the cla: yes labelJul 11, 2024
@NathanWalkerNathanWalker changed the titleOrigin/feat/grid layout ios optimisationperf(ios): gridlayout optimizationsJul 12, 2024
@NathanWalker
Copy link
Contributor

@SeanKelly369 possible to run some perf metrics before/after these changes?

@SeanKelly369
Copy link
Author

@NathanWalker what approach do you recommend I used to capture the performance? I could create a listview with items containing gridlayouts and calculate how much time it takes for the list to full render.

@NathanWalker
Copy link
Contributor

That would be a good baseline to start with I think@SeanKelly369 Also a page with perhaps 100 Gridlayouts with 2 labels in them (copy/paste them out) and measure the time it takes to navigate to that page with 100 gridlayouts before/after (could bump that to 200, 300 or even 400 to see broader differences to get good idea).

@SeanKelly369
Copy link
Author

@NathanWalker When running this last year, the performance difference was in the nano-seconds. I'd say this isn't worth the risk merging for this reason. It's possibly dated by now as well.

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@SeanKelly369@NathanWalker

[8]ページ先頭

©2009-2025 Movatter.jp