Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork1.7k
fix(ios): Nested modals#10448
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Open
farfromrefug wants to merge600 commits intoNativeScript:mainChoose a base branch
base:main
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
Open
fix(ios): Nested modals#10448
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
# Conflicts:#packages/core/application/index.ios.ts#packages/core/index.ts
…sublayers (NativeScript#9881)" (NativeScript#9917)This reverts commit3d882b0.
…for example to fake disabled state while allowing touch)
This will allow to test for `isLoaded` and deffer heavy operations on backStack pages
…once the view is loaded again
launchEvent is not triggered at the same moment on iOS and Android. iOS is firing after setting the rootView while Android is firing before.Consequently if you need an event for when the rootView is set (to read/write root css variables) you need such event
…instead of a `Color`
…le to access the `ns-root` class which comply with css specs (for example to read root css variables)
on iOS as the UILayoutViewController can be used for other widget we need to let it know it is for modal so that it still loads/unloads the view (there was a test for parent).
… can be instantiated within android layouts
# Conflicts:#packages/core/ui/transition/page-transition.android.ts
farfromrefug added a commit to nativescript-community/ui-material-components that referenced this pull requestNov 24, 2023
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
we can now show modal on top of each other
it will even work if a dialog is showing
Screen.Recording.2023-11-24.at.11.13.10.mov