Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

chore: Delete generated aar files#10372

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
farfromrefug wants to merge2 commits intomain
base:main
Choose a base branch
Loading
fromfarfromrefug-delete-generated

Conversation

farfromrefug
Copy link
Collaborator

@farfromrefugfarfromrefug commentedSep 4, 2023•
edited by NathanWalker
Loading

PR Checklist

What is the current behavior?

What is the new behavior?

Fixes/Implements/Closes #[Issue Number].

@cla-botcla-botbot added the cla: yes labelSep 4, 2023
Copy link
Contributor

@NathanWalkerNathanWalker left a comment•
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Appears widgets-release.aar needs to stay since ui-mobile-base is not built with npm release, prebuilt to save time, but core.aar may can be removed.

@CatchABus
Copy link
Contributor

CatchABus commentedSep 4, 2023•
edited
Loading

@farfromrefug It seems thatcore.aar was not purposely generated. I think it might be a result of a build in NativeScript/apps? Not sure.
We could removecore.aar and add a gitignore rule for it to make sure nobody commits it again in the future.

@farfromrefug
Copy link
CollaboratorAuthor

@NathanWalker it should be best to rebuild it on each npm release to ensure we are up to date with sources. I do that in my fork without any issue

@farfromrefug
Copy link
CollaboratorAuthor

@CatchABus indeed I will add a gitignore

CatchABus reacted with thumbs up emoji

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@NathanWalkerNathanWalkerNathanWalker requested changes

Assignees
No one assigned
Labels
Projects
None yet
Milestone
9.0
Development

Successfully merging this pull request may close these issues.

3 participants
@farfromrefug@CatchABus@NathanWalker
[8]ページ先頭
©2009-2025 Movatter.jp