NotificationsYou must be signed in to change notification settings
Fork1.7k
Star24.9k

feat: allow custom image scales on iOS#10212

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Draft

edusperoni wants to merge2 commits intomain

base:main

Choose a base branch

fromfeat/image-scale-ios

Draft

feat: allow custom image scales on iOS#10212

edusperoni wants to merge2 commits intomainfromfeat/image-scale-ios

+162 −51

Conversation

Copy link

Contributor

edusperoni commentedFeb 14, 2023

PR Checklist

The PR title follows our guidelines:https://github.com/NativeScript/NativeScript/blob/master/tools/notes/CONTRIBUTING.md#commit-messages.
There is an issue for the bug/feature this PR is for. To avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it.
You have signed theCLA.
All existing tests are passing:https://github.com/NativeScript/NativeScript/blob/master/tools/notes/DevelopmentWorkflow.md#running-unit-tests-application.
Tests for the changes are included -https://github.com/NativeScript/NativeScript/blob/master/tools/notes/WritingUnitTests.md.

What is the current behavior?

Images are always loaded with scale 1.0 (if they are files/resources then they're loaded with the appropriate scale when@2x.png is provided, for example)

What is the new behavior?

Allows you to set a hardcoded scale for the image.

feat: allow custom image scales on iOS

af106de

Copy link

nx-cloudbot commentedFeb 14, 2023•
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commitaf106de. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

✅ Successfully ran 2 targets

Sent with 💌 fromNxCloud.

cla-botbot added the cla: yes label

Feb 14, 2023

Copy link

ContributorAuthor

edusperoni commentedFeb 14, 2023

This might be too much of a burden to support in the future (especially if we decide to support orientation as well).

This is a viable alternative that's around 0.02ms slower and doesn't require any code to support:

function setImageSourceScale(source: ImageSource, scale: number) {  const image = source.ios;  return new ImageSource(UIImage.imageWithCGImageScaleOrientation(image.CGImage, scale, image.imageOrientation));}