☁️ Nx Cloud Report

CI is running/has finished running commands for commite816919. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

Sent with 💌 fromNxCloud.

@farfromrefug What impact will this have for devs that use unregistered apis inside their apps?
For instance, I could make use ofjava.text.* (e.g. SimpleDateFormat) which I don't see there.

@CatchABus yes if your app was not setting the correct native api usage from the app code it might fail now if it was "covered" by N native-api-usage. But I would not call that a regression in the sense that your app should handle that.
By the almost all community plugins set the correct native-api-usage for android. Not sure about nativescript plugins

This is a tough task to test, but what I'm doing is comparing ths to what I get from runninghttps://github.com/jcassidyav/generate-metadata-filter and comparing the gaps in each.

I haven't gone through everything but so far I have found these missing rules:

"android.content:ClipData",
"android.content:ContentResolver",
"android.graphics.drawable:StateListDrawable",
"android.webkit:URLUtil"

@jcassidyav nice will add those. BTW what is the real difference between android.content:ContentResolver andandroid.content:ContentResolver* . From what i have tested metadata are even bigger withandroid.content:ContentResolver which does not really make sense to me

EDIT: it seems my old tests about * were wrong. I tested again and * behave as expected and is thus not needed here.

@farfromrefug That is great at least it makes sense.

I think though that the * were hiding another problem, e.g.

"android.widget:ImageView","android.widget.ImageView:ScaleType",

Does not allow access toandroid.widget.ImageView.ScaleType but this works:

     "android.widget:ImageView",     "android.widget:ImageView.ScaleType",

I think it is
LHS = package name
RHS = class name

previouslyandroid.widget:ImageView*, was allowing the class nameImageView.ScaleType.

@jcassidyav wow that is a big issue ! thanks for catching this. I was updating all my plugins with that change, might have broken stuff!

@jcassidyav i updated the file. Does that look good to you?
Also removedandroidx.appcompat:R.attr as i dont think we need it

@farfromrefug When I run the generator against core I getandroid-native-api-usage.zip.

It may be too aggressive in picking up what is required but it is picking up some rules which are definitely required, I haven’t had a chance to look at the discrepancies yet.

It is easy to spot things which are just newed up in the typescript, once they have been highlighted, but if it is the type of a parameter to something else then very difficult.

But here is one example that is required:

"android.view.accessibility:AccessibilityManager.TouchExplorationStateChangeListener",

Also "android.inputmethodservice.Keyboard:Key" should be "android.inputmethodservice:Keyboard.Key",

@jcassidyav OK great i LL take a look

@farfromrefug I was able to get the /apps/automated tests running with the usage enabled by adding:

These may be only used in the test code ( hard to tell for sure):

  "androidx.appcompat.content.res:AppCompatResources",        "android.os:MessageQueue",        "android.os:Message",        "android.view:ViewGroup.MarginLayoutParams",

These are definitly used in core:

        "android.graphics:ColorFilter",        "android.widget:TabHost.TabSpec",        "androidx.transition:Explode",        "java.lang:Runtime",        "android.widget:FrameLayout.LayoutParams",        "android.view:View.AccessibilityDelegate",        "java.lang.reflect:Method",        "java.lang.reflect:AccessibleObject",        "android.widget:HorizontalScrollView",        "androidx.core.widget:NestedScrollView",        "android.view:WindowManager.LayoutParams",        "android.view:WindowManager",}

@jcassidyav thanks a lot. I was adding missing by testing in my production apps. I will run the tests too!
Thanks for helping on this!

@jcassidyav
aboutandroid.graphics:ColorFilter i dont think we need it. We only usegetColorFilter in the tests andsetColorFilter is only used with a color.

"android.widget:FrameLayout.LayoutParams", i dont see where it is used. We useCommonLayoutParams which inheritsandroid.widget.FrameLayout.LayoutParams but we dont actually use any method fromandroid.widget.FrameLayout.LayoutParams

"java.lang.reflect:AccessibleObject", i dont think we use that class. we usejava.lang.reflect.Field which inheritsjava.lang.reflect:AccessibleObject but we dont seem to be needing to marshall it. Though we do use it in the tests!

"android.widget:HorizontalScrollView" we use a class inheriting this but i dont think we need the methods from that parent class

"android.view:WindowManager.LayoutParams","android.view:WindowManager", cant find where we use those. Do you know?

@farfromrefug

java.lang.reflect:AccessibleObject from my tests is required because we call setAccessible.
android.widget:HorizontalScrollViewsmoothScrollTo is called.
android.view:WindowManager.LayoutParams comes fromhere
android.graphics:ColorFilter I think you are correct I didn't look closely at what the params to setColorFilter were.

The others, you are probably correct also, the tests fall apart so completly I thought they were used in core. That said for a small cost maybe they are worth keeping to let the tests run?

@jcassidyavsmoothScrollTo you are right!HorizontalScrollView does NOT inheriteNestedScrollView1
java.lang.reflect:AccessibleObject you are right too used by list-picker!
android.view:WindowManager.LayoutParams i just tested and that line works withoutandroid.view:WindowManager.LayoutParams. The reason is that thesoftInputMode returns an int even if it is part ofandroid.view:WindowManager.LayoutParams. So the getter + setter will work

About the test ones i actually added them to the appsApp_Resources so we should not need to add them to the core.

As a note on what all that can do, i pushed metadata filtering + proguard to its best (might even do better):

• use very detailed whitelist for N and plugins
• use whitelist to auto generate proguard file
• added and use a new custom fieldproguard_blacklist to my appnative-api-usage.json which i use to tell gradle which classes it can fully remove
  The result are those:
• without native-api-usage/gradle: 18.4mb apk and 2900ms app cold start(lowest)
• with native-api-usage/gradle: 14.4mb apk and 2700ms app cold start(lowest)

Seems to me it is worse going as detailed as possible

@farfromrefug Strange, I get
Caused by: java.lang.NoSuchMethodError: no non-static method "Landroid/view/Window;.getAttributes()Landroid/view/ViewGroup$LayoutParams;"

when calling getAttributes() on a window without specifyingandroid.view:WindowManager.LayoutParams in the usage

@jcassidyav indeed weird I will investigate. Thanks !

@jcassidyav i added all the fixes we talked about. Evenandroid.view:WindowManager.LayoutParams cause even though it does not crash here, your explanation makes sense