- Notifications
You must be signed in to change notification settings - Fork233
Handle unsupported device attributes gracefully#1409
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Open
Andy-Jost wants to merge2 commits intoNVIDIA:mainChoose a base branch fromAndy-Jost:nvbug5605010
base:main
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
+5 −1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
…ries against older drivers.
Contributor
ContributorAuthor
Andy-Jost commentedDec 18, 2025
/ok to testdef7312 |
|
ContributorAuthor
Andy-Jost commentedDec 18, 2025
/ok to test7e05f5a |
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
Summary
Adds defensive error handling in
DeviceProperties._get_attribute()to gracefully handle cases wherecuDeviceGetAttributereturnsCUDA_ERROR_INVALID_VALUEfor unsupported attributes.Changes
_get_attributein_device.pyxto check forCUDA_ERROR_INVALID_VALUEbefore raising an exception0as a conservative defaultvulkan_cig_supported),0meansFalse0indicates "not supported" or "disabled"Rationale
This addresses two scenarios:
CU_DEVICE_ATTRIBUTE_VULKAN_CIG_SUPPORTED) withCUDA_ERROR_INVALID_VALUEPreviously, these scenarios would cause
DevicePropertiesproperties to raiseCUDAErrorexceptions, breaking tests and user code. With this change, unsupported attributes return sensible defaults (0/False) instead of raising exceptions.Test Coverage
CUDA_ERROR_INVALID_VALUE(e.g.,test_device.py) will now pass by returning0Related Work