Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Skip a UVM-Heavy Test Under Compute Sanitizer#1400

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
leofang merged 1 commit intoNVIDIA:mainfromAndy-Jost:disable-tests-for-release
Dec 18, 2025

Conversation

@Andy-Jost
Copy link
Contributor

@Andy-JostAndy-Jost commentedDec 17, 2025•
edited
Loading

Summary

Adjust CI to improve debuggability of long-running tests.

Changes

  • Add--durations=0 to CIpytest invocations so logs report per-test timings.
  • Skipcuda_core/tests/test_helpers.py::test_patterngen_seeds when running under compute-sanitizer (detected viacuda_python_test_helpers.under_compute_sanitizer()), since this test can become extremely slow under sanitizer/UVM-heavy behavior.

Rationale

test_patterngen_seeds performs many syncs and host/device-visible memory comparisons; under compute-sanitizer this can balloon to very long runtimes in some CI environments. Skipping it under sanitizer keeps the CI signal while avoiding hour-scale jobs.

Test plan

  • CI

@Andy-JostAndy-Jost self-assigned thisDec 17, 2025
@copy-pr-bot
Copy link
Contributor

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilitieshere.

Contributors can view more details about this messagehere.

@Andy-JostAndy-Jost changed the titleSkip test_latchkernelSkip tests in preparation for releaseDec 17, 2025
@Andy-JostAndy-Jost marked this pull request as draftDecember 17, 2025 20:02
@Andy-Jost
Copy link
ContributorAuthor

/ok to testec93c12

copy-pr-bot[bot] reacted with thumbs up emoji

@github-actions

This comment has been minimized.

@leofangleofang added this to thecuda.core beta 10 milestoneDec 17, 2025
@leofangleofang added bugSomething isn't working P0High priority - Must do! testImprovements or additions to tests cuda.coreEverything related to the cuda.core module labelsDec 17, 2025
@Andy-JostAndy-Jostforce-pushed thedisable-tests-for-release branch 2 times, most recently fromce6b1b5 toe3183abCompareDecember 17, 2025 21:58
@Andy-Jost
Copy link
ContributorAuthor

/ok to teste3183ab

copy-pr-bot[bot] reacted with thumbs up emoji

@Andy-Jost
Copy link
ContributorAuthor

/ok to testcb86bd1

copy-pr-bot[bot] reacted with thumbs up emoji

@Andy-Jost
Copy link
ContributorAuthor

/ok to test8823fcc

copy-pr-bot[bot] reacted with thumbs up emoji

- Add --durations=0 to CI pytest invocations to report per-test timings.- Add cuda_python_test_helpers.under_compute_sanitizer() and use it to skip  the UVM-heavy PatternGen seed test under compute-sanitizer.
@Andy-JostAndy-Jostforce-pushed thedisable-tests-for-release branch from8823fcc tocbe5b2dCompareDecember 17, 2025 23:42
@Andy-Jost
Copy link
ContributorAuthor

/ok to testcbe5b2d

copy-pr-bot[bot] reacted with thumbs up emoji

"LD:${CUDA_PATHFINDER_TEST_LOAD_NVIDIA_DYNAMIC_LIB_STRICTNESS}" \
"FH:${CUDA_PATHFINDER_TEST_FIND_NVIDIA_HEADERS_STRICTNESS}"
pytest -ra -s -v tests/|& tee /tmp/pathfinder_test_log.txt
pytest -ra -s -v--durations=0tests/|& tee /tmp/pathfinder_test_log.txt
Copy link
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

It seems reasonable to report test times so that these issues are easier to debug in the future.

leofang reacted with thumbs up emoji
@Andy-JostAndy-Jost changed the titleSkip tests in preparation for releaseSkip a UVM-Heavy Test Under Compute SanitizerDec 17, 2025
@Andy-JostAndy-Jost marked this pull request as ready for reviewDecember 17, 2025 23:46
@Andy-Jost
Copy link
ContributorAuthor

CI confirms the fix. This test was taking >20min:

CI / Test linux-64 / py3.12, 12.9.1, local, l4 (push)Successful in 6m

@Andy-Jost
Copy link
ContributorAuthor

Longest durations now reported in the test logs:

============================== slowest durations ===============================7.42s call     tests/memory_ipc/test_workerpool.py::TestIpcWorkerPool::test_main[3]6.67s call     tests/memory_ipc/test_workerpool.py::TestIpcWorkerPoolUsingRegistry::test_main[3]6.64s call     tests/memory_ipc/test_workerpool.py::TestIpcWorkerPoolUsingIPCDescriptors::test_main[3]6.63s call     tests/memory_ipc/test_workerpool.py::TestIpcWorkerPoolUsingRegistry::test_main[1]6.44s call     tests/memory_ipc/test_send_buffers.py::TestIpcReexport::test_main[DeviceMR]6.38s call     tests/memory_ipc/test_workerpool.py::TestIpcWorkerPool::test_main[1]5.60s call     tests/memory_ipc/test_memory_ipc.py::TestIPCSharedAllocationHandleAndBufferObjects::test_main[DeviceMR]5.57s call     tests/memory_ipc/test_memory_ipc.py::TestIPCSharedAllocationHandleAndBufferDescriptors::test_main[DeviceMR]4.50s call     tests/memory_ipc/test_memory_ipc.py::TestIPCMempoolMultiple::test_main[DeviceMR]4.43s call     tests/memory_ipc/test_send_buffers.py::TestIpcSendBuffers::test_main[1]4.40s call     tests/memory_ipc/test_workerpool.py::TestIpcWorkerPoolUsingIPCDescriptors::test_main[1]4.39s call     tests/memory_ipc/test_serialize.py::TestObjectSerializationDirect::test_main[DeviceMR]3.42s call     tests/memory_ipc/test_event_ipc.py::TestEventIpc::test_main[DeviceMR]3.36s call     tests/memory_ipc/test_event_ipc.py::TestIpcEventProperties::test_main[False-True-True]3.36s call     tests/memory_ipc/test_errors.py::TestImportWrongMR::test_main[DeviceMR]3.36s call     tests/memory_ipc/test_send_buffers.py::TestIpcSendBuffers::test_main[3]3.35s call     tests/memory_ipc/test_errors.py::TestDanglingBuffer::test_main[DeviceMR]3.35s call     tests/memory_ipc/test_event_ipc.py::TestIpcEventProperties::test_main[False-False-True]3.35s call     tests/memory_ipc/test_event_ipc.py::TestIpcEventProperties::test_main[False-True-False]3.35s call     tests/memory_ipc/test_event_ipc.py::TestIpcEventProperties::test_main[True-False-True]3.35s call     tests/memory_ipc/test_event_ipc.py::TestIpcEventProperties::test_main[True-True-False]3.35s call     tests/memory_ipc/test_event_ipc.py::TestIpcEventProperties::test_main[False-False-False]3.34s call     tests/memory_ipc/test_serialize.py::TestObjectSerializationWithMR::test_main[DeviceMR]3.34s call     tests/memory_ipc/test_serialize.py::TestObjectPassing::test_main[DeviceMR]3.33s call     tests/memory_ipc/test_event_ipc.py::TestIpcEventProperties::test_main[True-False-False]3.32s call     tests/memory_ipc/test_event_ipc.py::TestIpcEventProperties::test_main[True-True-True]3.32s call     tests/memory_ipc/test_memory_ipc.py::TestIpcMempool::test_main[DeviceMR]3.31s call     tests/memory_ipc/test_errors.py::TestImportBuffer::test_main[DeviceMR]2.65s call     tests/memory_ipc/test_errors.py::TestAllocFromImportedMr::test_main[DeviceMR]2.39s call     tests/example_tests/test_basic_examples.py::TestExamples::test_example[/__w/cuda-python/cuda-python/cuda_core/tests/example_tests/../../examples/vector_add.py]2.35s call     tests/example_tests/test_basic_examples.py::TestExamples::test_example[/__w/cuda-python/cuda-python/cuda_core/tests/example_tests/../../examples/saxpy.py]2.25s call     tests/example_tests/test_basic_examples.py::TestExamples::test_example[/__w/cuda-python/cuda-python/cuda_core/tests/example_tests/../../examples/memory_ops.py]1.65s call     tests/test_helpers.py::test_latchkernel

@leofangleofangenabled auto-merge (squash)December 18, 2025 00:11
@leofangleofang merged commit083315c intoNVIDIA:mainDec 18, 2025
80 checks passed
@github-actions
Copy link

Doc Preview CI
Preview removed because the pull request was closed or merged.

@Andy-JostAndy-Jost deleted the disable-tests-for-release branchDecember 18, 2025 15:48
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@leofangleofangleofang approved these changes

Assignees

@Andy-JostAndy-Jost

Labels

bugSomething isn't workingcuda.coreEverything related to the cuda.core moduleP0High priority - Must do!testImprovements or additions to tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@Andy-Jost@leofang
[8]ページ先頭
©2009-2025 Movatter.jp