This repository was archived by the owner on Mar 21, 2024. It is now read-only.
- Notifications
You must be signed in to change notification settings - Fork449
Initial port to new monorepo build system.#704
Draft
alliepiper wants to merge14 commits intoNVIDIA:mainChoose a base branch
base:main
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
28 tasks
robertmaynard suggested changesMay 30, 2023
In Now that we will be synchronizing versions across components, we aren't going to try and support mix&match different versions of components. |
Comment on lines +140 to +142
| if (CUB_ENABLE_RDC_TESTS OR CUB_FORCE_RDC) | ||
| set(use_rdc_for_catch2_utils ON) | ||
| endif() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Looks like else branch:
Suggested change
| if (CUB_ENABLE_RDC_TESTS OR CUB_FORCE_RDC) | |
| set(use_rdc_for_catch2_utils ON) | |
| endif() | |
| if (CUB_ENABLE_RDC_TESTS OR CUB_FORCE_RDC) | |
| set(use_rdc_for_catch2_utils ON) | |
| endif() |
This allows the install rules to be generated for all projects evenwhen the dev builds are disabled.
These are now handled at the CCCL level, using newer and morerobust techniques.
ab1c756 tob729edbCompareSign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Labels
None yet
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.