This repository was archived by the owner on Mar 21, 2024. It is now read-only.
- Notifications
You must be signed in to change notification settings - Fork449
Remove Equals and friends#364
Merged
gevtushenko merged 2 commits intoNVIDIA:mainfromgevtushenko:main-feature/github/remove_equalsDec 16, 2021
Merged
Remove Equals and friends#364
gevtushenko merged 2 commits intoNVIDIA:mainfromgevtushenko:main-feature/github/remove_equalsDec 16, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
alliepiper approved these changesSep 21, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Thanks for taking the time to modernize this! We need to rename and move theVoidIteratorGuard trait into a detail namespace, the rest of my comments are suggestions.
We should do something similar for the Thrust traits eventually. We can just alias most of them to thestd:: traits instead of deprecating them, since the thrust traits should be syntactically equivalent.
47f3fa3 toe9fdc65Compare2c8ad27 to46f0765Compare46f0765 tof0b9edaComparegpuCI:NVIDIA/thrust/pull/1579 |
alliepiper approved these changesDec 14, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Need to addressthis comment, but otherwise LGTM. Thanks again, this is great :)
867db29 toe141237Comparee141237 to3c1f417Compare3c1f417 to9bab145CompareSign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Labels
P2: nice to haveDesired, but not necessary. release: breaking changeInclude in "Breaking Changes" section of release notes. testing: gpuCI passedPassed gpuCI testing. testing: internal ci passedPassed internal NVIDIA CI (DVS).
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is related tothe issue and deprecates:
If(replaced withstd::conditional)Equals(replaced withstd::is_same)IsPointer(replaced withstd::is_pointer)IsVolatile(replaced withstd::is_volatile)RemoveQualifiers(replaced withstd::remove_cv)EnableIf(replaced withstd::enable_if)Some tests seem to take about 6% less time to compile with these changes.