Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[None][infra] - Request idle time exemption for OCI jobs#9528

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
chzblych wants to merge1 commit intoNVIDIA:main
base:main
Choose a base branch
Loading
fromchzblych:revert-oci

Conversation

@chzblych
Copy link
Collaborator

@chzblychchzblych commentedNov 27, 2025•
edited by coderabbitaibot
Loading

Summary by CodeRabbit

Bug Fixes

  • Added GPU idle exemption for certain OCI hosts during test runs (90-minute window).
  • Improved script path handling in test execution to ensure proper argument processing.

✏️ Tip: You can customize this high-level summary in your review settings.

Description

Test Coverage

PR Checklist

Please review the following before submitting your PR:

  • PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.

  • PR FollowsTRT-LLM CODING GUIDELINES to the best of your knowledge.

  • Test cases are provided for new code paths (seetest instructions)

  • Any new dependencies have been scanned for license and vulnerabilities

  • CODEOWNERS updated if ownership changes

  • Documentation updated as needed

  • Updatetava architecture diagram if there is a significant design change in PR.

  • The reviewers assigned automatically/manually are appropriate for the PR.

  • Please check this after reviewing the above items as appropriate for this PR.

GitHub Bot Help

/bot [-h] ['run', 'kill', 'skip', 'reuse-pipeline'] ...

Provide a user friendly way for developers to interact with a Jenkins server.

Run/bot [-h|--help] to print this help message.

See details below for each supported subcommand.

run [--reuse-test (optional)pipeline-id --disable-fail-fast --skip-test --stage-list "A10-PyTorch-1, xxx" --gpu-type "A30, H100_PCIe" --test-backend "pytorch, cpp" --add-multi-gpu-test --only-multi-gpu-test --disable-multi-gpu-test --post-merge --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx" --detailed-log --debug(experimental)]

Launch build/test pipelines. All previously running jobs will be killed.

--reuse-test (optional)pipeline-id(OPTIONAL) : Allow the new pipeline to reuse build artifacts and skip successful test stages from a specified pipeline or the last pipeline if no pipeline-id is indicated. If the Git commit ID has changed, this option will be always ignored. The DEFAULT behavior of the bot is to reuse build artifacts and successful test results from the last pipeline.

--disable-reuse-test(OPTIONAL) : Explicitly prevent the pipeline from reusing build artifacts and skipping successful test stages from a previous pipeline. Ensure that all builds and tests are run regardless of previous successes.

--disable-fail-fast(OPTIONAL) : Disable fail fast on build/tests/infra failures.

--skip-test(OPTIONAL) : Skip all test stages, but still run build stages, package stages and sanity check stages. Note: DoesNOT update GitHub check status.

--stage-list "A10-PyTorch-1, xxx"(OPTIONAL) : Only run the specified test stages. Examples: "A10-PyTorch-1, xxx". Note: DoesNOT update GitHub check status.

--gpu-type "A30, H100_PCIe"(OPTIONAL) : Only run the test stages on the specified GPU types. Examples: "A30, H100_PCIe". Note: DoesNOT update GitHub check status.

--test-backend "pytorch, cpp"(OPTIONAL) : Skip test stages which don't match the specified backends. Only support [pytorch, cpp, tensorrt, triton]. Examples: "pytorch, cpp" (does not run test stages with tensorrt or triton backend). Note: DoesNOT update GitHub pipeline status.

--only-multi-gpu-test(OPTIONAL) : Only run the multi-GPU tests. Note: DoesNOT update GitHub check status.

--disable-multi-gpu-test(OPTIONAL) : Disable the multi-GPU tests. Note: DoesNOT update GitHub check status.

--add-multi-gpu-test(OPTIONAL) : Force run the multi-GPU tests in addition to running L0 pre-merge pipeline.

--post-merge(OPTIONAL) : Run the L0 post-merge pipeline instead of the ordinary L0 pre-merge pipeline.

--extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx"(OPTIONAL) : Run the ordinary L0 pre-merge pipeline and specified test stages. Examples: --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx".

--detailed-log(OPTIONAL) : Enable flushing out all logs to the Jenkins console. This will significantly increase the log volume and may slow down the job.

--debug(OPTIONAL) :Experimental feature. Enable access to the CI container for debugging purpose. Note: Specify exactly one stage in thestage-list parameter to access the appropriate container environment. Note: DoesNOT update GitHub check status.

For guidance on mapping tests to stage names, seedocs/source/reference/ci-overview.md
and thescripts/test_to_stage_mapping.py helper.

kill

kill

Kill all running builds associated with pull request.

skip

skip --comment COMMENT

Skip testing for latest commit on pull request.--comment "Reason for skipping build/test" is required. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

reuse-pipeline

reuse-pipeline

Reuse a previous pipeline to validate current commit. This action will also kill all currently running builds associated with the pull request. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

@chzblych
Copy link
CollaboratorAuthor

/bot run --gpu-type "DGX_H100, GB200"

@coderabbitai
Copy link
Contributor

📝 Walkthrough

Walkthrough

Library reference updated to use bloom-jenkins-shared-lib@dev-yanchaol-oci. Added conditional exemption comment for specific OCI hosts to exempt Idle GPUs for 90 minutes in Slurm SBATCH submissions. Script path argument wrapped in quotes. SBATCH exemption comment prepended to output configuration.

Changes

Cohort / File(s)Summary
Jenkins Configuration
jenkins/L0_Test.groovy		Updated library reference to bloom-jenkins-shared-lib@dev-yanchaol-oci; added conditional exemption logic for OCI hosts (oci-nrt, oci-hsg, lbd-lax) to inject Slurm SBATCH comment exempting Idle GPUs for 90 minutes; prepended exemption comment to SBATCH --output line; wrapped script path argument in quotes for PyTest execution

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

  • Single file modification with straightforward logic additions
  • Conditional exemption comment logic for specific host names requires verification of host list accuracy
  • Ensure SBATCH comment syntax and GPU exemption parameters are correct for target OCI infrastructure

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)
Check nameStatusExplanationResolution
Description check⚠️ WarningThe PR description section is empty, containing only the template placeholder comment. No actual description explaining the changes, rationale, or test coverage was provided.Fill in the Description section explaining why idle time exemption is needed, the Test Coverage section listing relevant tests, and verify the PR Checklist items are appropriately addressed.
✅ Passed checks (2 passed)
Check nameStatusExplanation
Title check✅ PassedThe PR title clearly references the main change: requesting idle time exemption for OCI jobs, which aligns with the code modifications that add exemption comments for OCI hosts.
Docstring Coverage✅ PassedNo functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
📜 Recent review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between2f8bd6f andc68731f.

📒 Files selected for processing (1)
  • jenkins/L0_Test.groovy (3 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
  • GitHub Check: Check PR Checklist Resolution
  • GitHub Check: Pre-commit Check
🔇 Additional comments (4)
jenkins/L0_Test.groovy (4)

975-979:LGTM! Idle GPU exemption for OCI hosts.

The conditional exemption comment is well-implemented. The 90-minute idle GPU exemption is reasonable for ML workloads with long data/model loading times, and the JSON structure is correctly formatted for SLURM's OccupiedIdleGPUsJobReaper configuration.

980-981:SBATCH comment correctly prepended to output configuration.

The exemptionComment is properly integrated into the SBATCH directive. Note that whenexemptionComment is empty, this creates a double space before--output, but SBATCH handles this without issues.

1051-1060: I'll help you verify the review comment by examining how the quoted script path works with SSH execution. Let me search for theUtils.sshUserCmd implementation to understand the context.
<function_calls>

#!/bin/bash

Find Utils class files in the repository

find . -name "*.groovy" -type f | xargs grep -l "class Utils" | head -20


</function_calls>

Let me search more broadly for thesshUserCmd method:
<function_calls>

#!/bin/bash

Search for sshUserCmd method definition

rg -n "def sshUserCmd|sshUserCmd\s*=" --type groovy -A 5 -B 2


</function_calls>

Let me also check the context around the code change to understand how the script path is used:
<function_calls>

#!/bin/bash

Read the specific lines around 1051-1060 to see full context

sed -n '1045,1065p' jenkins/L0_Test.groovy


</function_calls>

Let me search for where Utils is defined or imported:
<function_calls>

#!/bin/bash

Look for Utils import or definition

rg -n "^import.*Utils|^class Utils" --type groovy | head -20


</function_calls>

Let me search more broadly for sshUserCmd calls to understand the usage pattern:
<function_calls>

#!/bin/bash

Find all usages of sshUserCmd to see how it's typically called

rg -n "sshUserCmd(" --type groovy -B 2 -A 3 | head -50


</function_calls>

1-1:Confirm the intent and temporary nature of the dev branch usage.

I was unable to access the repository or GitHub API to verify the context of this change. However, the review comment's concern is valid: usingbloom-jenkins-shared-lib@dev-yanchaol-oci (a development branch) alongsidetrtllm-jenkins-shared-lib@main (a stable branch) is atypical and warrants clarification.

Ensure that:

  • This dev branch reference is intentional for temporary testing purposes
  • The branch reference should be changed to a stable branch (e.g.,main,prod, or equivalent) before merging to production
  • Document why the dev branch is necessary if it must remain

Tip

📝 Customizable high-level summaries are now available in beta!

You can now customize how CodeRabbit generates thehigh-level summary in your pull requests — including its content, structure, tone, and formatting.

  • Provide your own instructions using thehigh_level_summary_instructions setting.
  • Format the summary however you like (bullet lists, tables, multi-section layouts, contributor stats, etc.).
  • Usehigh_level_summary_in_walkthrough to move the summary from the description to the walkthrough section.

Example instruction:

"Divide the high-level summary into five sections:

  1. 📝 Description — Summarize the main change in 50–60 words, explaining what was done.
  2. 📓 References — List relevant issues, discussions, documentation, or related PRs.
  3. 📦 Dependencies & Requirements — Mention any new/updated dependencies, environment variable changes, or configuration updates.
  4. 📊 Contributor Summary — Include a Markdown table showing contributions:
    | Contributor | Lines Added | Lines Removed | Files Changed |
  5. ✔️ Additional Notes — Add any extra reviewer context.
    Keep each section concise (under 200 words) and use bullet or numbered lists for clarity."

Note: This feature is currently in beta for Pro-tier users, and pricing will be announced later.

Thanks for usingCodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment@coderabbitai help to get the list of available commands and usage tips.

@tensorrt-cicd
Copy link
Collaborator

PR_Github #26063 [ run ] triggered by Bot. Commit:c68731f

@tensorrt-cicd
Copy link
Collaborator

PR_Github #26063 [ run ] completed with stateSUCCESS. Commit:c68731f
/LLM/main/L0_MergeRequest_PR pipeline #19786(Partly Tested) completed with status: 'FAILURE'

@chzblych
Copy link
CollaboratorAuthor

/bot run --gpu-type "DGX_H100, GB200" --disable-fail-fast

@tensorrt-cicd
Copy link
Collaborator

PR_Github #26103 [ run ] triggered by Bot. Commit:269e65d

@tensorrt-cicd
Copy link
Collaborator

PR_Github #26103 [ run ] completed with stateSUCCESS. Commit:269e65d
/LLM/main/L0_MergeRequest_PR pipeline #19819(Partly Tested) completed with status: 'ABORTED'

Signed-off-by: Yanchao Lu <yanchaol@nvidia.com>
@chzblych
Copy link
CollaboratorAuthor

/bot run --gpu-type "DGX_H100, GB200" --disable-fail-fast

@tensorrt-cicd
Copy link
Collaborator

PR_Github #26169 [ run ] triggered by Bot. Commit:7972547

@tensorrt-cicd
Copy link
Collaborator

PR_Github #26169 [ run ] completed with stateFAILURE. Commit:7972547

@chzblych
Copy link
CollaboratorAuthor

/bot run --gpu-type "DGX_H100, GB200" --disable-fail-fast

@tensorrt-cicd
Copy link
Collaborator

PR_Github #26170 [ run ] triggered by Bot. Commit:7972547

@tensorrt-cicd
Copy link
Collaborator

PR_Github #26170 [ run ] completed with stateSUCCESS. Commit:7972547
/LLM/main/L0_MergeRequest_PR pipeline #19878(Partly Tested) completed with status: 'FAILURE'

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@mlefeb01mlefeb01Awaiting requested review from mlefeb01mlefeb01 is a code owner automatically assigned from NVIDIA/trt-llm-ci-infra-devs

@crazydemocrazydemoAwaiting requested review from crazydemocrazydemo is a code owner automatically assigned from NVIDIA/trt-llm-infra-devs

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@chzblych@tensorrt-cicd
[8]ページ先頭
©2009-2025 Movatter.jp