- Notifications
You must be signed in to change notification settings - Fork1.9k
[None][fix] Fix the aux_stream in Llama4MinLatencyFusedMoE#9035
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
[None][fix] Fix the aux_stream in Llama4MinLatencyFusedMoE#9035
Uh oh!
There was an error while loading.Please reload this page.
Conversation
9ae4b49 tobdd6539Comparecoderabbitaibot commentedNov 10, 2025 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
📝 WalkthroughWalkthroughThe changes replace a single auxiliary stream parameter with a dictionary-based configuration in two Llama model classes. Parameter type shifts from Changes
Sequence Diagram(s)sequenceDiagram participant Caller participant LlamaClass as Llama4MinLatency{Linear/FusedMoE} participant BaseClass Note over Caller,LlamaClass `#DDDDFF`: New call site supplies aux_stream_dict Caller->>LlamaClass: __init__(..., aux_stream_dict=Dict[AuxStreamType, Stream]) LlamaClass->>BaseClass: super().__init__(..., aux_stream_dict=aux_stream_dict) BaseClass-->>LlamaClass: initialized with labeled auxiliary streams LlamaClass-->>Caller: instance readyEstimated code review effort🎯 2 (Simple) | ⏱️ ~5–10 minutes
Pre-merge checks and finishing touches❌ Failed checks (2 warnings)
✅ Passed checks (1 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
Thanks for usingCodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
kaiyux commentedNov 10, 2025
@jinyangyuan-nvidia Thanks a lot for the quick fix! |
jiahanc left a comment• edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I think theLlama4MinLatencyMoE also need update?
Also other classes likeLlama4MinLatencyDecoderLayer which calles theLlama4MinLatencyMoE
bdd6539 to9c37e06Comparejinyangyuan-nvidia commentedNov 10, 2025 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
The original code does not pass |
jiahanc left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Thanks for the fix!
jinyangyuan-nvidia commentedNov 10, 2025
/bot run |
tensorrt-cicd commentedNov 10, 2025
PR_Github #23980 [ run ] triggered by Bot. Commit: |
tensorrt-cicd commentedNov 10, 2025
PR_Github #23980 [ run ] completed with state |
jinyangyuan-nvidia commentedNov 10, 2025
/bot run |
tensorrt-cicd commentedNov 10, 2025
PR_Github #24014 [ run ] triggered by Bot. Commit: |
tensorrt-cicd commentedNov 10, 2025
PR_Github #24014 [ run ] completed with state |
kaiyux commentedNov 11, 2025
/bot run |
tensorrt-cicd commentedNov 11, 2025
PR_Github #24063 [ run ] triggered by Bot. Commit: |
tensorrt-cicd commentedNov 11, 2025
PR_Github #24063 [ run ] completed with state |
jinyangyuan-nvidia commentedNov 11, 2025
/bot run |
tensorrt-cicd commentedNov 11, 2025
PR_Github #24084 [ run ] triggered by Bot. Commit: |
tensorrt-cicd commentedNov 11, 2025
PR_Github #24084 [ run ] completed with state |
9c37e06 to78ac556Comparejinyangyuan-nvidia commentedNov 11, 2025
/bot run |
tensorrt-cicd commentedNov 11, 2025
PR_Github #24114 [ run ] triggered by Bot. Commit: |
tensorrt-cicd commentedNov 11, 2025
PR_Github #24114 [ run ] completed with state |
78ac556 tob16d9c9Comparejinyangyuan-nvidia commentedNov 11, 2025
/bot run |
tensorrt-cicd commentedNov 11, 2025
PR_Github #24186 [ run ] triggered by Bot. Commit: |
tensorrt-cicd commentedNov 12, 2025
PR_Github #24186 [ run ] completed with state |
b16d9c9 tofdb922eComparejinyangyuan-nvidia commentedNov 12, 2025
/bot run |
tensorrt-cicd commentedNov 12, 2025
PR_Github #24225 [ run ] triggered by Bot. Commit: |
tensorrt-cicd commentedNov 12, 2025
PR_Github #24225 [ run ] completed with state |
kaiyux commentedNov 12, 2025
/bot run |
tensorrt-cicd commentedNov 12, 2025
PR_Github #24244 [ run ] triggered by Bot. Commit: |
tensorrt-cicd commentedNov 12, 2025
PR_Github #24244 [ run ] completed with state |
Signed-off-by: Jinyang Yuan <154768711+jinyangyuan-nvidia@users.noreply.github.com>
fdb922e toefe2c03Comparekaiyux commentedNov 13, 2025
/bot run --disable-fail-fast |
tensorrt-cicd commentedNov 13, 2025
PR_Github #24420 [ run ] triggered by Bot. Commit: |
tensorrt-cicd commentedNov 13, 2025
PR_Github #24420 [ run ] completed with state |
12f339f intoNVIDIA:mainUh oh!
There was an error while loading.Please reload this page.
Signed-off-by: Jinyang Yuan <154768711+jinyangyuan-nvidia@users.noreply.github.com>
Signed-off-by: Jinyang Yuan <154768711+jinyangyuan-nvidia@users.noreply.github.com>
Uh oh!
There was an error while loading.Please reload this page.
Summary by CodeRabbit
Description
Test Coverage
PR Checklist
Please review the following before submitting your PR:
PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.
PR FollowsTRT-LLM CODING GUIDELINES to the best of your knowledge.
Test cases are provided for new code paths (seetest instructions)
Any new dependencies have been scanned for license and vulnerabilities
CODEOWNERS updated if ownership changes
Documentation updated as needed
Updatetava architecture diagram if there is a significant design change in PR.
The reviewers assigned automatically/manually are appropriate for the PR.
Please check this after reviewing the above items as appropriate for this PR.
GitHub Bot Help
/bot [-h] ['run', 'kill', 'skip', 'reuse-pipeline'] ...Provide a user friendly way for developers to interact with a Jenkins server.
Run
/bot [-h|--help]to print this help message.See details below for each supported subcommand.
run [--reuse-test (optional)pipeline-id --disable-fail-fast --skip-test --stage-list "A10-PyTorch-1, xxx" --gpu-type "A30, H100_PCIe" --test-backend "pytorch, cpp" --add-multi-gpu-test --only-multi-gpu-test --disable-multi-gpu-test --post-merge --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx" --detailed-log --debug(experimental)]Launch build/test pipelines. All previously running jobs will be killed.
--reuse-test (optional)pipeline-id(OPTIONAL) : Allow the new pipeline to reuse build artifacts and skip successful test stages from a specified pipeline or the last pipeline if no pipeline-id is indicated. If the Git commit ID has changed, this option will be always ignored. The DEFAULT behavior of the bot is to reuse build artifacts and successful test results from the last pipeline.--disable-reuse-test(OPTIONAL) : Explicitly prevent the pipeline from reusing build artifacts and skipping successful test stages from a previous pipeline. Ensure that all builds and tests are run regardless of previous successes.--disable-fail-fast(OPTIONAL) : Disable fail fast on build/tests/infra failures.--skip-test(OPTIONAL) : Skip all test stages, but still run build stages, package stages and sanity check stages. Note: DoesNOT update GitHub check status.--stage-list "A10-PyTorch-1, xxx"(OPTIONAL) : Only run the specified test stages. Examples: "A10-PyTorch-1, xxx". Note: DoesNOT update GitHub check status.--gpu-type "A30, H100_PCIe"(OPTIONAL) : Only run the test stages on the specified GPU types. Examples: "A30, H100_PCIe". Note: DoesNOT update GitHub check status.--test-backend "pytorch, cpp"(OPTIONAL) : Skip test stages which don't match the specified backends. Only support [pytorch, cpp, tensorrt, triton]. Examples: "pytorch, cpp" (does not run test stages with tensorrt or triton backend). Note: DoesNOT update GitHub pipeline status.--only-multi-gpu-test(OPTIONAL) : Only run the multi-GPU tests. Note: DoesNOT update GitHub check status.--disable-multi-gpu-test(OPTIONAL) : Disable the multi-GPU tests. Note: DoesNOT update GitHub check status.--add-multi-gpu-test(OPTIONAL) : Force run the multi-GPU tests in addition to running L0 pre-merge pipeline.--post-merge(OPTIONAL) : Run the L0 post-merge pipeline instead of the ordinary L0 pre-merge pipeline.--extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx"(OPTIONAL) : Run the ordinary L0 pre-merge pipeline and specified test stages. Examples: --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx".--detailed-log(OPTIONAL) : Enable flushing out all logs to the Jenkins console. This will significantly increase the log volume and may slow down the job.--debug(OPTIONAL) :Experimental feature. Enable access to the CI container for debugging purpose. Note: Specify exactly one stage in thestage-listparameter to access the appropriate container environment. Note: DoesNOT update GitHub check status.For guidance on mapping tests to stage names, see
docs/source/reference/ci-overview.mdand the
scripts/test_to_stage_mapping.pyhelper.kill
killKill all running builds associated with pull request.
skip
skip --comment COMMENTSkip testing for latest commit on pull request.
--comment "Reason for skipping build/test"is required. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.reuse-pipeline
reuse-pipelineReuse a previous pipeline to validate current commit. This action will also kill all currently running builds associated with the pull request. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.