Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

[None][infra] Add split algorithm for slurm#8516

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

@EmmaQiaoCh
Copy link
Collaborator

@EmmaQiaoChEmmaQiaoCh commentedOct 21, 2025
edited by coderabbitaibot
Loading

Summary by CodeRabbit

  • Chores
    • Enhanced test execution efficiency by implementing an optimized algorithm for distributing test workloads across test splits, improving overall test performance and resource allocation.

Description

Test Coverage

PR Checklist

Please review the following before submitting your PR:

  • PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.

  • PR FollowsTRT-LLM CODING GUIDELINES to the best of your knowledge.

  • Test cases are provided for new code paths (seetest instructions)

  • Any new dependencies have been scanned for license and vulnerabilities

  • CODEOWNERS updated if ownership changes

  • Documentation updated as needed

  • The reviewers assigned automatically/manually are appropriate for the PR.

  • Please check this after reviewing the above items as appropriate for this PR.

GitHub Bot Help

/bot [-h] ['run', 'kill', 'skip', 'reuse-pipeline'] ...

Provide a user friendly way for developers to interact with a Jenkins server.

Run/bot [-h|--help] to print this help message.

See details below for each supported subcommand.

run [--reuse-test (optional)pipeline-id --disable-fail-fast --skip-test --stage-list "A10-PyTorch-1, xxx" --gpu-type "A30, H100_PCIe" --test-backend "pytorch, cpp" --add-multi-gpu-test --only-multi-gpu-test --disable-multi-gpu-test --post-merge --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx" --detailed-log --debug(experimental)]

Launch build/test pipelines. All previously running jobs will be killed.

--reuse-test (optional)pipeline-id(OPTIONAL) : Allow the new pipeline to reuse build artifacts and skip successful test stages from a specified pipeline or the last pipeline if no pipeline-id is indicated. If the Git commit ID has changed, this option will be always ignored. The DEFAULT behavior of the bot is to reuse build artifacts and successful test results from the last pipeline.

--disable-reuse-test(OPTIONAL) : Explicitly prevent the pipeline from reusing build artifacts and skipping successful test stages from a previous pipeline. Ensure that all builds and tests are run regardless of previous successes.

--disable-fail-fast(OPTIONAL) : Disable fail fast on build/tests/infra failures.

--skip-test(OPTIONAL) : Skip all test stages, but still run build stages, package stages and sanity check stages. Note: DoesNOT update GitHub check status.

--stage-list "A10-PyTorch-1, xxx"(OPTIONAL) : Only run the specified test stages. Examples: "A10-PyTorch-1, xxx". Note: DoesNOT update GitHub check status.

--gpu-type "A30, H100_PCIe"(OPTIONAL) : Only run the test stages on the specified GPU types. Examples: "A30, H100_PCIe". Note: DoesNOT update GitHub check status.

--test-backend "pytorch, cpp"(OPTIONAL) : Skip test stages which don't match the specified backends. Only support [pytorch, cpp, tensorrt, triton]. Examples: "pytorch, cpp" (does not run test stages with tensorrt or triton backend). Note: DoesNOT update GitHub pipeline status.

--only-multi-gpu-test(OPTIONAL) : Only run the multi-GPU tests. Note: DoesNOT update GitHub check status.

--disable-multi-gpu-test(OPTIONAL) : Disable the multi-GPU tests. Note: DoesNOT update GitHub check status.

--add-multi-gpu-test(OPTIONAL) : Force run the multi-GPU tests in addition to running L0 pre-merge pipeline.

--post-merge(OPTIONAL) : Run the L0 post-merge pipeline instead of the ordinary L0 pre-merge pipeline.

--extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx"(OPTIONAL) : Run the ordinary L0 pre-merge pipeline and specified test stages. Examples: --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx".

--detailed-log(OPTIONAL) : Enable flushing out all logs to the Jenkins console. This will significantly increase the log volume and may slow down the job.

--debug(OPTIONAL) :Experimental feature. Enable access to the CI container for debugging purpose. Note: Specify exactly one stage in thestage-list parameter to access the appropriate container environment. Note: DoesNOT update GitHub check status.

For guidance on mapping tests to stage names, seedocs/source/reference/ci-overview.md
and thescripts/test_to_stage_mapping.py helper.

kill

kill

Kill all running builds associated with pull request.

skip

skip --comment COMMENT

Skip testing for latest commit on pull request.--comment "Reason for skipping build/test" is required. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

reuse-pipeline

reuse-pipeline

Reuse a previous pipeline to validate current commit. This action will also kill all currently running builds associated with the pull request. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

Signed-off-by: qqiao <qqiao@nvidia.com>
@EmmaQiaoChEmmaQiaoCh requested review froma team ascode ownersOctober 21, 2025 03:23
@EmmaQiaoCh
Copy link
CollaboratorAuthor

/bot run --stage-list "GB200-8_GPUs-2_Nodes-PyTorch-Post-Merge-1, GB200-8_GPUs-2_Nodes-PyTorch-Post-Merge-2, GB200-8_GPUs-2_Nodes-PyTorch-Post-Merge-3, GB200-8_GPUs-2_Nodes-PyTorch-Post-Merge-4, GB200-8_GPUs-2_Nodes-PyTorch-Post-Merge-5, GB200-8_GPUs-2_Nodes-PyTorch-Post-Merge-6, GB200-8_GPUs-2_Nodes-PyTorch-Post-Merge-7, GB200-8_GPUs-2_Nodes-PyTorch-Post-Merge-8, GB200-8_GPUs-2_Nodes-PyTorch-Post-Merge-9"

@coderabbitai
Copy link
Contributor

📝 Walkthrough

Walkthrough

The change adds the--splitting-algorithm least_duration argument to two pytest invocations in therunLLMTestlistWithSbatch function. This modifies the test-splitting strategy to use the least_duration algorithm for test distribution across splits and groups.

Changes

Cohort / File(s)Summary
Test splitting configuration
jenkins/L0_Test.groovy
Added--splitting-algorithm least_duration parameter to pytest command invocations (2 occurrences) to specify the test-splitting strategy

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)
Check nameStatusExplanationResolution
Description Check⚠️ WarningThe pull request description is largely incomplete. While the PR title follows the template correctly, the two critical content sections—Description and Test Coverage—are entirely empty, containing only placeholder comment text from the template with no actual explanation of the issue, solution, or test coverage. The PR Checklist is present but mostly unchecked, and only the GitHub Bot Help section is populated. This fails to provide necessary context for reviewers to understand the rationale and validation of the changes.Add a substantive Description section explaining why the--splitting-algorithm least_duration argument was added and what problem it solves. Add a Test Coverage section listing the relevant test stages or test cases that validate this change, particularly the slurm-based test stages affected by the splitting algorithm modification. Complete the PR Checklist items as appropriate for this infrastructure change.
✅ Passed checks (2 passed)
Check nameStatusExplanation
Title Check✅ PassedThe pull request title "[None][infra] Add split algorithm for slurm" follows the required template format with a valid ticket reference [None], appropriate type classification [infra], and a clear summary. The title directly relates to the main change in the pull request, which adds a new--splitting-algorithm least_duration argument to pytest invocations in the Jenkins test configuration file to change how tests are divided across splits when running on slurm.
Docstring Coverage✅ PassedNo functions found in the changes. Docstring coverage check skipped.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

📜 Recent review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and betweenab4b996 andcd6d8bd.

📒 Files selected for processing (1)
  • jenkins/L0_Test.groovy (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
  • GitHub Check: Pre-commit Check
🔇 Additional comments (1)
jenkins/L0_Test.groovy (1)

897-897:The code change is sound; no action required.

Theleast_duration algorithm is valid and provides more balanced test distribution by assigning each test to the group with the smallest current duration. pytest-split automatically assumes average test execution time for any test without duration information stored, so the change will function correctly even on first runs. The plugin is already listed in requirements-dev.txt and properly configured to support this algorithm.


Thanks for usingCodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment@coderabbitai help to get the list of available commands and usage tips.

@tensorrt-cicd
Copy link
Collaborator

PR_Github #21988 [ run ] triggered by Bot. Commit:cd6d8bd

@tensorrt-cicd
Copy link
Collaborator

PR_Github #21988 [ run ] completed with stateSUCCESS. Commit:cd6d8bd
/LLM/main/L0_MergeRequest_PR pipeline #16580(Partly Tested) completed with status: 'SUCCESS'

@EmmaQiaoCh
Copy link
CollaboratorAuthor

/bot skip --comment "slurm test stages passed"

@EmmaQiaoChEmmaQiaoChenabled auto-merge (squash)October 21, 2025 06:24
@tensorrt-cicd
Copy link
Collaborator

PR_Github #22012 [ skip ] triggered by Bot. Commit:cd6d8bd

@tensorrt-cicd
Copy link
Collaborator

PR_Github #22012 [ skip ] completed with stateSUCCESS. Commit:cd6d8bd
Skipping testing for commitcd6d8bd

@EmmaQiaoChEmmaQiaoCh merged commitc72f6d1 intoNVIDIA:mainOct 21, 2025
8 of 9 checks passed
govind-ramnarayan pushed a commit to nv-auto-deploy/TensorRT-LLM that referenced this pull requestOct 21, 2025
yufeiwu-nv pushed a commit to yufeiwu-nv/TensorRT-LLM that referenced this pull requestOct 24, 2025
Signed-off-by: qqiao <qqiao@nvidia.com>Signed-off-by: yufeiwu-nv <230315618+yufeiwu-nv@users.noreply.github.com>
dominicshanshan pushed a commit to dominicshanshan/TensorRT-LLM that referenced this pull requestNov 1, 2025
dominicshanshan pushed a commit to dominicshanshan/TensorRT-LLM that referenced this pull requestNov 3, 2025
dominicshanshan pushed a commit to dominicshanshan/TensorRT-LLM that referenced this pull requestNov 3, 2025
dominicshanshan pushed a commit to dominicshanshan/TensorRT-LLM that referenced this pull requestNov 3, 2025
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@chzblychchzblychchzblych approved these changes

@ruodilruodilAwaiting requested review from ruodilruodil is a code owner automatically assigned from NVIDIA/trt-llm-ci-infra-devs

@kxdckxdcAwaiting requested review from kxdckxdc is a code owner automatically assigned from NVIDIA/trt-llm-infra-devs

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@EmmaQiaoCh@tensorrt-cicd@chzblych

[8]ページ先頭

©2009-2025 Movatter.jp