Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

[None][chore] AutoDeploy: replace HF's deprecated keyword torch_dtype --> dtype#8510

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

@lucaslie
Copy link
Member

@lucaslielucaslie commentedOct 20, 2025
edited by coderabbitaibot
Loading

HF is deprecating thetorch_dtype keyword. This PR is a follow-up to#8263 where it was already deprecated for the PT backend to address the deprecation in AutoDeploy as well

Summary by CodeRabbit

  • Refactor
    • Improved handling of data type specifications during model loading for better consistency and maintainability.

Description

Test Coverage

PR Checklist

Please review the following before submitting your PR:

  • PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.

  • PR FollowsTRT-LLM CODING GUIDELINES to the best of your knowledge.

  • Test cases are provided for new code paths (seetest instructions)

  • Any new dependencies have been scanned for license and vulnerabilities

  • CODEOWNERS updated if ownership changes

  • Documentation updated as needed

  • The reviewers assigned automatically/manually are appropriate for the PR.

  • Please check this after reviewing the above items as appropriate for this PR.

GitHub Bot Help

/bot [-h] ['run', 'kill', 'skip', 'reuse-pipeline'] ...

Provide a user friendly way for developers to interact with a Jenkins server.

Run/bot [-h|--help] to print this help message.

See details below for each supported subcommand.

run [--reuse-test (optional)pipeline-id --disable-fail-fast --skip-test --stage-list "A10-PyTorch-1, xxx" --gpu-type "A30, H100_PCIe" --test-backend "pytorch, cpp" --add-multi-gpu-test --only-multi-gpu-test --disable-multi-gpu-test --post-merge --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx" --detailed-log --debug(experimental)]

Launch build/test pipelines. All previously running jobs will be killed.

--reuse-test (optional)pipeline-id(OPTIONAL) : Allow the new pipeline to reuse build artifacts and skip successful test stages from a specified pipeline or the last pipeline if no pipeline-id is indicated. If the Git commit ID has changed, this option will be always ignored. The DEFAULT behavior of the bot is to reuse build artifacts and successful test results from the last pipeline.

--disable-reuse-test(OPTIONAL) : Explicitly prevent the pipeline from reusing build artifacts and skipping successful test stages from a previous pipeline. Ensure that all builds and tests are run regardless of previous successes.

--disable-fail-fast(OPTIONAL) : Disable fail fast on build/tests/infra failures.

--skip-test(OPTIONAL) : Skip all test stages, but still run build stages, package stages and sanity check stages. Note: DoesNOT update GitHub check status.

--stage-list "A10-PyTorch-1, xxx"(OPTIONAL) : Only run the specified test stages. Examples: "A10-PyTorch-1, xxx". Note: DoesNOT update GitHub check status.

--gpu-type "A30, H100_PCIe"(OPTIONAL) : Only run the test stages on the specified GPU types. Examples: "A30, H100_PCIe". Note: DoesNOT update GitHub check status.

--test-backend "pytorch, cpp"(OPTIONAL) : Skip test stages which don't match the specified backends. Only support [pytorch, cpp, tensorrt, triton]. Examples: "pytorch, cpp" (does not run test stages with tensorrt or triton backend). Note: DoesNOT update GitHub pipeline status.

--only-multi-gpu-test(OPTIONAL) : Only run the multi-GPU tests. Note: DoesNOT update GitHub check status.

--disable-multi-gpu-test(OPTIONAL) : Disable the multi-GPU tests. Note: DoesNOT update GitHub check status.

--add-multi-gpu-test(OPTIONAL) : Force run the multi-GPU tests in addition to running L0 pre-merge pipeline.

--post-merge(OPTIONAL) : Run the L0 post-merge pipeline instead of the ordinary L0 pre-merge pipeline.

--extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx"(OPTIONAL) : Run the ordinary L0 pre-merge pipeline and specified test stages. Examples: --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx".

--detailed-log(OPTIONAL) : Enable flushing out all logs to the Jenkins console. This will significantly increase the log volume and may slow down the job.

--debug(OPTIONAL) :Experimental feature. Enable access to the CI container for debugging purpose. Note: Specify exactly one stage in thestage-list parameter to access the appropriate container environment. Note: DoesNOT update GitHub check status.

For guidance on mapping tests to stage names, seedocs/source/reference/ci-overview.md
and thescripts/test_to_stage_mapping.py helper.

kill

kill

Kill all running builds associated with pull request.

skip

skip --comment COMMENT

Skip testing for latest commit on pull request.--comment "Reason for skipping build/test" is required. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

reuse-pipeline

reuse-pipeline

Reuse a previous pipeline to validate current commit. This action will also kill all currently running builds associated with the pull request. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

@lucaslie
Copy link
MemberAuthor

/bot run

@lucaslielucaslieforce-pushed thell/torch_dtype_deprecation branch from81aeb50 to47140c1CompareOctober 20, 2025 19:43
@lucaslielucaslie removed the request for review froma teamOctober 20, 2025 19:43
@coderabbitai
Copy link
Contributor

coderabbitaibot commentedOct 20, 2025
edited
Loading

📝 Walkthrough

Walkthrough

The PR refactors dtype specification in HuggingFace model loading. Dtype normalization moves from initialization time to config-update time, converting string dtype values to torch.dtype objects. The parameter key shifts from "torch_dtype" to "dtype" across implementation and tests.

Changes

Cohort / File(s)Change Summary
HF model dtype handling
tensorrt_llm/_torch/auto_deploy/models/hf.py
Removed runtime normalization oftorch_dtype in__init__. Added dtype string-to-torch.dtype conversion in_recursive_update_config for "torch_dtype" and "dtype" keys viasetattr(). Updatedbuild_and_load_model to use"dtype": "auto" instead of"torch_dtype": "auto".
Test configurations
tests/unittest/_torch/auto_deploy/_utils_test/_model_test_utils.py,tests/unittest/_torch/auto_deploy/unit/singlegpu/models/test_hybrid_patches.py
Updated model_kwargs parameter key from"torch_dtype" to"dtype" with value"bfloat16" in test fixtures for Bamba and Nemotron models.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

The changes are well-localized with straightforward refactoring: dtype normalization relocates from initialization to config updates, and parameter keys rename consistently across files. Test updates are repetitive. Minimal review complexity, though understanding the rationale for the normalization shift requires brief context.

Pre-merge checks and finishing touches

❌ Failed checks (2 warnings)
Check nameStatusExplanationResolution
Description Check⚠️ WarningThe PR description is largely incomplete compared to the required template structure. While the author provided a brief contextual note about HF deprecating torch_dtype and referenced a related PR, the two critical sections—Description and Test Coverage—are empty and only contain placeholder comments from the template. The Description section should explain the issue and solution in detail, and the Test Coverage section should list the relevant tests that safeguard the changes. Only the PR Checklist box was marked as complete, but the substantive explanatory sections that help reviewers understand the scope and testing strategy are missing.Add a detailed Description section explaining the issue (HF's deprecation of torch_dtype) and the solution (replacing it with dtype across AutoDeploy). Include a Test Coverage section that lists which tests validate the dtype parameter changes, such as the tests modified in the PR (test_hybrid_patches.py and _model_test_utils.py). Briefly explain what behavioral changes, if any, result from this transition, and confirm that existing functionality is preserved.
Docstring Coverage⚠️ WarningDocstring coverage is 50.00% which is insufficient. The required threshold is 80.00%.You can run@coderabbitai generate docstrings to improve docstring coverage.
✅ Passed checks (1 passed)
Check nameStatusExplanation
Title Check✅ PassedThe PR title "[None][chore] AutoDeploy: replace HF's deprecated keyword torch_dtype --> dtype" is well-formed and directly reflects the primary change across all three modified files. The title follows the required format with the ticket reference and type indicator, and it clearly communicates that this is a refactoring task to replace a deprecated HuggingFace keyword with its modern equivalent. The changes in the raw summary confirm this is the main objective: updating the AutoDeploy code, test configurations, and test files to use "dtype" instead of "torch_dtype".
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for usingCodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment@coderabbitai help to get the list of available commands and usage tips.

Copy link
Contributor

@coderabbitaicoderabbitaibot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Actionable comments posted: 1

📜 Review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between9b289d5 and47140c1.

📒 Files selected for processing (3)
  • tensorrt_llm/_torch/auto_deploy/models/hf.py (2 hunks)
  • tests/unittest/_torch/auto_deploy/_utils_test/_model_test_utils.py (2 hunks)
  • tests/unittest/_torch/auto_deploy/unit/singlegpu/models/test_hybrid_patches.py (1 hunks)
🧰 Additional context used
📓 Path-based instructions (3)
**/*.{h,hpp,hh,hxx,cpp,cxx,cc,cu,cuh,py}

📄 CodeRabbit inference engine (CODING_GUIDELINES.md)

Use only spaces, no tabs; indent with 4 spaces.

Files:

  • tests/unittest/_torch/auto_deploy/unit/singlegpu/models/test_hybrid_patches.py
  • tests/unittest/_torch/auto_deploy/_utils_test/_model_test_utils.py
  • tensorrt_llm/_torch/auto_deploy/models/hf.py
**/*.py

📄 CodeRabbit inference engine (CODING_GUIDELINES.md)

**/*.py: Python code must target Python 3.8+.
Indent Python code with 4 spaces; do not use tabs.
Maintain module namespace when importing; prefer 'from package.subpackage import foo' then 'foo.SomeClass()' instead of importing the class directly.
Python filenames should be snake_case (e.g., some_file.py).
Python classes use PascalCase names.
Functions and methods use snake_case names.
Local variables use snake_case; prefix 'k' for variables that start with a number (e.g., k_99th_percentile).
Global variables use upper SNAKE_CASE prefixed with 'G' (e.g., G_MY_GLOBAL).
Constants use upper SNAKE_CASE (e.g., MY_CONSTANT).
Avoid shadowing variables from an outer scope.
Initialize all externally visible members of a class in the constructor.
Prefer docstrings for interfaces that may be used outside a file; comments for in-function or file-local interfaces.
Use Google-style docstrings for classes and functions (Sphinx-parsable).
Document attributes and variables inline so they render under the class/function docstring.
Avoid reflection when a simpler, explicit approach suffices (e.g., avoid dict(**locals()) patterns).
In try/except, catch the most specific exceptions possible.
For duck-typing try/except, keep the try body minimal and use else for the main logic.

Files:

  • tests/unittest/_torch/auto_deploy/unit/singlegpu/models/test_hybrid_patches.py
  • tests/unittest/_torch/auto_deploy/_utils_test/_model_test_utils.py
  • tensorrt_llm/_torch/auto_deploy/models/hf.py
**/*.{cpp,cxx,cc,h,hpp,hh,hxx,cu,cuh,py}

📄 CodeRabbit inference engine (CODING_GUIDELINES.md)

Prepend the NVIDIA Apache-2.0 copyright header with current year to the top of all source files (e.g., .cpp, .h, .cu, .py).

Files:

  • tests/unittest/_torch/auto_deploy/unit/singlegpu/models/test_hybrid_patches.py
  • tests/unittest/_torch/auto_deploy/_utils_test/_model_test_utils.py
  • tensorrt_llm/_torch/auto_deploy/models/hf.py
🧠 Learnings (1)
📓 Common learnings
Learnt from: ixlmarPR: NVIDIA/TensorRT-LLM#8263File: examples/models/contrib/sdxl/run_sdxl.py:0-0Timestamp: 2025-10-13T13:55:04.170ZLearning: The `diffusers` library (e.g., `DiffusionPipeline`, `StableDiffusionXLPipeline`, `StableDiffusion3Pipeline`) uses the `torch_dtype` parameter in `from_pretrained()` calls, not `dtype`. Only the `transformers` library has migrated to using `dtype`.
🔇 Additional comments (3)
tensorrt_llm/_torch/auto_deploy/models/hf.py (1)

276-276:LGTM! Correct migration todtype for transformers.

The change fromtorch_dtype todtype is correct for thetransformers library, which has migrated to the new parameter name. HuggingFace'sfrom_pretrained will handle the"auto" value appropriately.

Based on learnings

tests/unittest/_torch/auto_deploy/unit/singlegpu/models/test_hybrid_patches.py (1)

51-51:LGTM! Test updated consistently with implementation.

The change fromtorch_dtype todtype aligns with the implementation changes inhf.py. The concrete dtype value"bfloat16" will be correctly converted totorch.bfloat16 by the_recursive_update_config logic.

tests/unittest/_torch/auto_deploy/_utils_test/_model_test_utils.py (1)

468-468:LGTM! Model configs updated consistently.

Both model configurations correctly updated fromtorch_dtype todtype. The changes align with the implementation inhf.py and ensure test coverage for the new parameter name across different model types.

Also applies to: 487-487

@tensorrt-cicd
Copy link
Collaborator

PR_Github #21943 [ run ] triggered by Bot. Commit:47140c1

… --> dtypeSigned-off-by: Lucas Liebenwein <11156568+lucaslie@users.noreply.github.com>
@lucaslielucaslieforce-pushed thell/torch_dtype_deprecation branch from47140c1 toc1e4528CompareOctober 20, 2025 19:50
@lucaslie
Copy link
MemberAuthor

/bot run

@tensorrt-cicd
Copy link
Collaborator

PR_Github #21944 [ run ] triggered by Bot. Commit:c1e4528

@tensorrt-cicd
Copy link
Collaborator

PR_Github #21943 [ run ] completed with stateABORTED. Commit:47140c1
LLM/main/L0_MergeRequest_PR #16541(Blue Ocean) completed with status: ABORTED

@lucaslielucaslieenabled auto-merge (squash)October 20, 2025 20:31
@tensorrt-cicd
Copy link
Collaborator

PR_Github #21944 [ run ] completed with stateSUCCESS. Commit:c1e4528
/LLM/main/L0_MergeRequest_PR pipeline #16543 completed with status: 'FAILURE'

@lucaslie
Copy link
MemberAuthor

/bot run

@tensorrt-cicd
Copy link
Collaborator

PR_Github #21952 [ run ] triggered by Bot. Commit:c1e4528

@tensorrt-cicd
Copy link
Collaborator

PR_Github #21952 [ run ] completed with stateSUCCESS. Commit:c1e4528
/LLM/main/L0_MergeRequest_PR pipeline #16549 completed with status: 'FAILURE'

@lucaslie
Copy link
MemberAuthor

/bot run

@tensorrt-cicd
Copy link
Collaborator

PR_Github #22074 [ run ] triggered by Bot. Commit:c1e4528

@tensorrt-cicd
Copy link
Collaborator

PR_Github #22074 [ run ] completed with stateSUCCESS. Commit:c1e4528
/LLM/main/L0_MergeRequest_PR pipeline #16645 completed with status: 'FAILURE'

@lucaslie
Copy link
MemberAuthor

/bot run

@tensorrt-cicd
Copy link
Collaborator

PR_Github #22082 [ run ] triggered by Bot. Commit:747051c

@tensorrt-cicd
Copy link
Collaborator

PR_Github #22082 [ run ] completed with stateSUCCESS. Commit:747051c
/LLM/main/L0_MergeRequest_PR pipeline #16649 completed with status: 'SUCCESS'
Pipeline passed with automatic retried tests. Check thererun report for details.

@lucaslielucaslie merged commit9b54b3b intoNVIDIA:mainOct 21, 2025
5 checks passed
@github-project-automationgithub-project-automationbot moved this fromIn review toDone inAutoDeploy BoardOct 21, 2025
@lucaslielucaslie deleted the ll/torch_dtype_deprecation branchOctober 21, 2025 21:34
yufeiwu-nv pushed a commit to yufeiwu-nv/TensorRT-LLM that referenced this pull requestOct 24, 2025
… --> dtype (NVIDIA#8510)Signed-off-by: Lucas Liebenwein <11156568+lucaslie@users.noreply.github.com>Signed-off-by: yufeiwu-nv <230315618+yufeiwu-nv@users.noreply.github.com>
dominicshanshan pushed a commit to dominicshanshan/TensorRT-LLM that referenced this pull requestNov 1, 2025
… --> dtype (NVIDIA#8510)Signed-off-by: Lucas Liebenwein <11156568+lucaslie@users.noreply.github.com>
dominicshanshan pushed a commit to dominicshanshan/TensorRT-LLM that referenced this pull requestNov 3, 2025
… --> dtype (NVIDIA#8510)Signed-off-by: Lucas Liebenwein <11156568+lucaslie@users.noreply.github.com>
dominicshanshan pushed a commit to dominicshanshan/TensorRT-LLM that referenced this pull requestNov 3, 2025
… --> dtype (NVIDIA#8510)Signed-off-by: Lucas Liebenwein <11156568+lucaslie@users.noreply.github.com>
dominicshanshan pushed a commit to dominicshanshan/TensorRT-LLM that referenced this pull requestNov 3, 2025
… --> dtype (NVIDIA#8510)Signed-off-by: Lucas Liebenwein <11156568+lucaslie@users.noreply.github.com>
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@coderabbitaicoderabbitai[bot]coderabbitai[bot] left review comments

@MrGevaMrGevaMrGeva approved these changes

@govind-ramnarayangovind-ramnarayangovind-ramnarayan approved these changes

@nvchenghaoznvchenghaoznvchenghaoz approved these changes

@galagamgalagamAwaiting requested review from galagamgalagam is a code owner automatically assigned from NVIDIA/trt-llm-torch-autodeploy-devs

Assignees

@lucaslielucaslie

Labels

None yet

Projects

Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@lucaslie@tensorrt-cicd@MrGeva@govind-ramnarayan@nvchenghaoz

[8]ページ先頭

©2009-2025 Movatter.jp