Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

[None][fix] add gc for test fixture#8220

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
xinhe-nv merged 1 commit intoNVIDIA:mainfromxinhe-nv:hex-1.1
Oct 10, 2025
Merged

Conversation

@xinhe-nv
Copy link
Collaborator

@xinhe-nvxinhe-nv commentedOct 9, 2025
edited by coderabbitaibot
Loading

Summary by CodeRabbit

  • Tests
    • Improved reliability of GPU-related tests by enforcing a full memory cleanup after clearing CUDA cache.
    • Reduces intermittent out-of-memory issues and flakiness in CI and local test runs.
    • Leads to more consistent, deterministic test outcomes and faster recovery between GPU test cases.

Description

Test Coverage

PR Checklist

Please review the following before submitting your PR:

  • PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.

  • PR FollowsTRT-LLM CODING GUIDELINES to the best of your knowledge.

  • Test cases are provided for new code paths (seetest instructions)

  • Any new dependencies have been scanned for license and vulnerabilities

  • CODEOWNERS updated if ownership changes

  • Documentation updated as needed

  • The reviewers assigned automatically/manually are appropriate for the PR.

  • Please check this after reviewing the above items as appropriate for this PR.

GitHub Bot Help

/bot [-h] ['run', 'kill', 'skip', 'reuse-pipeline'] ...

Provide a user friendly way for developers to interact with a Jenkins server.

Run/bot [-h|--help] to print this help message.

See details below for each supported subcommand.

run [--reuse-test (optional)pipeline-id --disable-fail-fast --skip-test --stage-list "A10-PyTorch-1, xxx" --gpu-type "A30, H100_PCIe" --test-backend "pytorch, cpp" --add-multi-gpu-test --only-multi-gpu-test --disable-multi-gpu-test --post-merge --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx" --detailed-log --debug(experimental)]

Launch build/test pipelines. All previously running jobs will be killed.

--reuse-test (optional)pipeline-id(OPTIONAL) : Allow the new pipeline to reuse build artifacts and skip successful test stages from a specified pipeline or the last pipeline if no pipeline-id is indicated. If the Git commit ID has changed, this option will be always ignored. The DEFAULT behavior of the bot is to reuse build artifacts and successful test results from the last pipeline.

--disable-reuse-test(OPTIONAL) : Explicitly prevent the pipeline from reusing build artifacts and skipping successful test stages from a previous pipeline. Ensure that all builds and tests are run regardless of previous successes.

--disable-fail-fast(OPTIONAL) : Disable fail fast on build/tests/infra failures.

--skip-test(OPTIONAL) : Skip all test stages, but still run build stages, package stages and sanity check stages. Note: DoesNOT update GitHub check status.

--stage-list "A10-PyTorch-1, xxx"(OPTIONAL) : Only run the specified test stages. Examples: "A10-PyTorch-1, xxx". Note: DoesNOT update GitHub check status.

--gpu-type "A30, H100_PCIe"(OPTIONAL) : Only run the test stages on the specified GPU types. Examples: "A30, H100_PCIe". Note: DoesNOT update GitHub check status.

--test-backend "pytorch, cpp"(OPTIONAL) : Skip test stages which don't match the specified backends. Only support [pytorch, cpp, tensorrt, triton]. Examples: "pytorch, cpp" (does not run test stages with tensorrt or triton backend). Note: DoesNOT update GitHub pipeline status.

--only-multi-gpu-test(OPTIONAL) : Only run the multi-GPU tests. Note: DoesNOT update GitHub check status.

--disable-multi-gpu-test(OPTIONAL) : Disable the multi-GPU tests. Note: DoesNOT update GitHub check status.

--add-multi-gpu-test(OPTIONAL) : Force run the multi-GPU tests in addition to running L0 pre-merge pipeline.

--post-merge(OPTIONAL) : Run the L0 post-merge pipeline instead of the ordinary L0 pre-merge pipeline.

--extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx"(OPTIONAL) : Run the ordinary L0 pre-merge pipeline and specified test stages. Examples: --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx".

--detailed-log(OPTIONAL) : Enable flushing out all logs to the Jenkins console. This will significantly increase the log volume and may slow down the job.

--debug(OPTIONAL) :Experimental feature. Enable access to the CI container for debugging purpose. Note: Specify exactly one stage in thestage-list parameter to access the appropriate container environment. Note: DoesNOT update GitHub check status.

For guidance on mapping tests to stage names, seedocs/source/reference/ci-overview.md
and thescripts/test_to_stage_mapping.py helper.

kill

kill

Kill all running builds associated with pull request.

skip

skip --comment COMMENT

Skip testing for latest commit on pull request.--comment "Reason for skipping build/test" is required. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

reuse-pipeline

reuse-pipeline

Reuse a previous pipeline to validate current commit. This action will also kill all currently running builds associated with the pull request. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

@xinhe-nvxinhe-nv marked this pull request as ready for reviewOctober 9, 2025 07:59
@xinhe-nvxinhe-nvenabled auto-merge (squash)October 9, 2025 07:59
@coderabbitai
Copy link
Contributor

📝 Walkthrough

Walkthrough

Adds gc module import and invokes gc.collect() after torch.cuda.empty_cache() within the torch_empty_cache pytest fixture in tests/integration/defs/conftest.py. No changes to public APIs or exports.

Changes

Cohort / File(s)Summary
Test fixture memory cleanup
tests/integration/defs/conftest.py
Import gc; in torch_empty_cache fixture, call torch.cuda.empty_cache() then gc.collect() to force garbage collection after clearing CUDA cache.

Sequence Diagram(s)

sequenceDiagram  autonumber  participant T as Pytest Test  participant F as torch_empty_cache Fixture  participant C as torch.cuda  participant G as gc  T->>F: Use fixture  activate F  F->>C: empty_cache()  note right of C: Clear CUDA cached memory  F->>G: collect()  note right of G: Force Python garbage collection  deactivate F
Loading

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)
Check nameStatusExplanationResolution
Description Check⚠️ WarningThe pull request description is largely unfilled and retains only the template placeholders without any substantive content in the summary, Description, or Test Coverage sections. There is no actual explanation of the change or its motivation, nor are any test cases listed to validate the new behavior. Consequently, reviewers lack the context and information needed to assess and properly review this PR.Please fill in the summary with a concise overview, add a description of the issue and solution in the Description section, and list relevant tests under the Test Coverage heading so that reviewers can understand and verify the changes.
✅ Passed checks (2 passed)
Check nameStatusExplanation
Title Check✅ PassedThe title succinctly and accurately describes the main change by indicating that garbage collection support was added to the test fixture, matching the changeset of importing and invoking gc.collect() after clearing the CUDA cache.
Docstring Coverage✅ PassedDocstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment@coderabbitai help to get the list of available commands and usage tips.

Copy link
Contributor

@coderabbitaicoderabbitaibot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (1)
tests/integration/defs/conftest.py (1)

2521-2528:LGTM! The addition ofgc.collect() improves memory cleanup.

The combination oftorch.cuda.empty_cache() followed bygc.collect() is a sound pattern for thorough GPU memory cleanup in test fixtures. Theempty_cache() frees PyTorch's cached memory, whilegc.collect() ensures Python objects holding GPU tensor references are also cleaned up, reducing OOM risk.

Optional: Update the docstring to reflect the full cleanup behavior.

Consider updating the docstring to mention the garbage collection step:

 @pytest.fixture(autouse=True) def torch_empty_cache() -> None:     """-    Manually empty the torch CUDA cache before each test, to reduce risk of OOM errors.+    Manually empty the torch CUDA cache and trigger garbage collection before each test,+    to reduce risk of OOM errors.     """

Optional: Consider updating the copyright year.

As per coding guidelines, the copyright header should include the current year (2025) when modifying files. You could update line 1:

-# SPDX-FileCopyrightText: Copyright (c) 2022-2024 NVIDIA CORPORATION & AFFILIATES. All rights reserved.+# SPDX-FileCopyrightText: Copyright (c) 2022-2025 NVIDIA CORPORATION & AFFILIATES. All rights reserved.
📜 Review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between27677a3 andcfe5df6.

📒 Files selected for processing (1)
  • tests/integration/defs/conftest.py (2 hunks)
🧰 Additional context used
📓 Path-based instructions (3)
**/*.{h,hpp,hh,hxx,cpp,cxx,cc,cu,cuh,py}

📄 CodeRabbit inference engine (CODING_GUIDELINES.md)

Use only spaces, no tabs; indent with 4 spaces.

Files:

  • tests/integration/defs/conftest.py
**/*.py

📄 CodeRabbit inference engine (CODING_GUIDELINES.md)

**/*.py: Python code must target Python 3.8+.
Indent Python code with 4 spaces; do not use tabs.
Maintain module namespace when importing; prefer 'from package.subpackage import foo' then 'foo.SomeClass()' instead of importing the class directly.
Python filenames should be snake_case (e.g., some_file.py).
Python classes use PascalCase names.
Functions and methods use snake_case names.
Local variables use snake_case; prefix 'k' for variables that start with a number (e.g., k_99th_percentile).
Global variables use upper SNAKE_CASE prefixed with 'G' (e.g., G_MY_GLOBAL).
Constants use upper SNAKE_CASE (e.g., MY_CONSTANT).
Avoid shadowing variables from an outer scope.
Initialize all externally visible members of a class in the constructor.
Prefer docstrings for interfaces that may be used outside a file; comments for in-function or file-local interfaces.
Use Google-style docstrings for classes and functions (Sphinx-parsable).
Document attributes and variables inline so they render under the class/function docstring.
Avoid reflection when a simpler, explicit approach suffices (e.g., avoid dict(**locals()) patterns).
In try/except, catch the most specific exceptions possible.
For duck-typing try/except, keep the try body minimal and use else for the main logic.

Files:

  • tests/integration/defs/conftest.py
**/*.{cpp,cxx,cc,h,hpp,hh,hxx,cu,cuh,py}

📄 CodeRabbit inference engine (CODING_GUIDELINES.md)

Prepend the NVIDIA Apache-2.0 copyright header with current year to the top of all source files (e.g., .cpp, .h, .cu, .py).

Files:

  • tests/integration/defs/conftest.py
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
  • GitHub Check: Pre-commit Check
🔇 Additional comments (1)
tests/integration/defs/conftest.py (1)

18-18:LGTM!

Thegc module import is correctly placed and necessary for thegc.collect() call added to thetorch_empty_cache fixture.

@xinhe-nv
Copy link
CollaboratorAuthor

/bot run

@tensorrt-cicd
Copy link
Collaborator

PR_Github #20943 [ run ] triggered by Bot

@crazydemo
Copy link
Collaborator

/bot run --skip-test

@tensorrt-cicd
Copy link
Collaborator

PR_Github #20965 [ run ] triggered by Bot

@tensorrt-cicd
Copy link
Collaborator

PR_Github #20943 [ run ] completed with stateABORTED
LLM/main/L0_MergeRequest_PR #15843(Blue Ocean) completed with status: ABORTED

@xinhe-nvxinhe-nvforce-pushed thehex-1.1 branch 2 times, most recently frome71be99 to75f7542CompareOctober 10, 2025 06:00
@xinhe-nv
Copy link
CollaboratorAuthor

/bot run --skip-test

@tensorrt-cicd
Copy link
Collaborator

PR_Github #20978 [ run ] triggered by Bot

@tensorrt-cicd
Copy link
Collaborator

PR_Github #20965 [ run ] completed with stateABORTED
LLM/main/L0_MergeRequest_PR #15856(Blue Ocean) completed with status: ABORTED

@tensorrt-cicd
Copy link
Collaborator

PR_Github #20978 [ run ] completed with stateSUCCESS
/LLM/main/L0_MergeRequest_PR pipeline #15865(Partly Tested) completed with status: 'SUCCESS'
Pipeline passed with automatic retried tests. Check thererun report for details.

Signed-off-by: Xin He (SW-GPU) <200704525+xinhe-nv@users.noreply.github.com>
@xinhe-nv
Copy link
CollaboratorAuthor

/bot reuse-pipeline

@tensorrt-cicd
Copy link
Collaborator

PR_Github #21019 [ reuse-pipeline ] triggered by Bot

@tensorrt-cicd
Copy link
Collaborator

PR_Github #21019 [ reuse-pipeline ] completed with stateSUCCESS
ReusingPR_Github #20978(Partly Tested) for commitcceb4f0

@xinhe-nvxinhe-nv merged commit2655995 intoNVIDIA:mainOct 10, 2025
5 checks passed
@xinhe-nvxinhe-nv deleted the hex-1.1 branchOctober 10, 2025 10:23
yufeiwu-nv pushed a commit to yufeiwu-nv/TensorRT-LLM that referenced this pull requestOct 24, 2025
Signed-off-by: Xin He (SW-GPU) <200704525+xinhe-nv@users.noreply.github.com>Signed-off-by: yufeiwu-nv <230315618+yufeiwu-nv@users.noreply.github.com>
dominicshanshan pushed a commit to dominicshanshan/TensorRT-LLM that referenced this pull requestNov 1, 2025
Signed-off-by: Xin He (SW-GPU) <200704525+xinhe-nv@users.noreply.github.com>
dominicshanshan pushed a commit to dominicshanshan/TensorRT-LLM that referenced this pull requestNov 3, 2025
Signed-off-by: Xin He (SW-GPU) <200704525+xinhe-nv@users.noreply.github.com>
dominicshanshan pushed a commit to dominicshanshan/TensorRT-LLM that referenced this pull requestNov 3, 2025
Signed-off-by: Xin He (SW-GPU) <200704525+xinhe-nv@users.noreply.github.com>
dominicshanshan pushed a commit to dominicshanshan/TensorRT-LLM that referenced this pull requestNov 3, 2025
Signed-off-by: Xin He (SW-GPU) <200704525+xinhe-nv@users.noreply.github.com>
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@coderabbitaicoderabbitai[bot]coderabbitai[bot] left review comments

@crazydemocrazydemocrazydemo approved these changes

@litaotjulitaotjuAwaiting requested review from litaotju

@StanleySun639StanleySun639Awaiting requested review from StanleySun639

@LarryXFlyLarryXFlyAwaiting requested review from LarryXFly

@jieli-matrixjieli-matrixAwaiting requested review from jieli-matrix

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@xinhe-nv@tensorrt-cicd@crazydemo

[8]ページ先頭

©2009-2025 Movatter.jp