Bug Fixes
- Ensured stable installs for the Gemma example by constraining NumPy to versions below 2, preventing incompatibility issues.
Tests
- Simplified integration test setup for the Gemma example to install dependencies from its requirements file, removing platform-specific logic and improving reliability.

Description

Test Coverage

PR Checklist

Please review the following before submitting your PR:

PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.
PR FollowsTRT-LLM CODING GUIDELINES to the best of your knowledge.
Test cases are provided for new code paths (seetest instructions)
Any new dependencies have been scanned for license and vulnerabilities
CODEOWNERS updated if ownership changes
Documentation updated as needed
The reviewers assigned automatically/manually are appropriate for the PR.
Please check this after reviewing the above items as appropriate for this PR.

GitHub Bot Help

/bot [-h] ['run', 'kill', 'skip', 'reuse-pipeline'] ...

Provide a user friendly way for developers to interact with a Jenkins server.

Run/bot [-h|--help] to print this help message.

See details below for each supported subcommand.

run [--reuse-test (optional)pipeline-id --disable-fail-fast --skip-test --stage-list "A10-PyTorch-1, xxx" --gpu-type "A30, H100_PCIe" --test-backend "pytorch, cpp" --add-multi-gpu-test --only-multi-gpu-test --disable-multi-gpu-test --post-merge --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx" --detailed-log --debug(experimental)]

Launch build/test pipelines. All previously running jobs will be killed.

--reuse-test (optional)pipeline-id(OPTIONAL) : Allow the new pipeline to reuse build artifacts and skip successful test stages from a specified pipeline or the last pipeline if no pipeline-id is indicated. If the Git commit ID has changed, this option will be always ignored. The DEFAULT behavior of the bot is to reuse build artifacts and successful test results from the last pipeline.

--disable-reuse-test(OPTIONAL) : Explicitly prevent the pipeline from reusing build artifacts and skipping successful test stages from a previous pipeline. Ensure that all builds and tests are run regardless of previous successes.

--disable-fail-fast(OPTIONAL) : Disable fail fast on build/tests/infra failures.

--skip-test(OPTIONAL) : Skip all test stages, but still run build stages, package stages and sanity check stages. Note: DoesNOT update GitHub check status.

--stage-list "A10-PyTorch-1, xxx"(OPTIONAL) : Only run the specified test stages. Examples: "A10-PyTorch-1, xxx". Note: DoesNOT update GitHub check status.

--gpu-type "A30, H100_PCIe"(OPTIONAL) : Only run the test stages on the specified GPU types. Examples: "A30, H100_PCIe". Note: DoesNOT update GitHub check status.

--test-backend "pytorch, cpp"(OPTIONAL) : Skip test stages which don't match the specified backends. Only support [pytorch, cpp, tensorrt, triton]. Examples: "pytorch, cpp" (does not run test stages with tensorrt or triton backend). Note: DoesNOT update GitHub pipeline status.

--only-multi-gpu-test(OPTIONAL) : Only run the multi-GPU tests. Note: DoesNOT update GitHub check status.

--disable-multi-gpu-test(OPTIONAL) : Disable the multi-GPU tests. Note: DoesNOT update GitHub check status.

--add-multi-gpu-test(OPTIONAL) : Force run the multi-GPU tests in addition to running L0 pre-merge pipeline.

--post-merge(OPTIONAL) : Run the L0 post-merge pipeline instead of the ordinary L0 pre-merge pipeline.

--extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx"(OPTIONAL) : Run the ordinary L0 pre-merge pipeline and specified test stages. Examples: --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx".

--detailed-log(OPTIONAL) : Enable flushing out all logs to the Jenkins console. This will significantly increase the log volume and may slow down the job.

--debug(OPTIONAL) :Experimental feature. Enable access to the CI container for debugging purpose. Note: Specify exactly one stage in thestage-list parameter to access the appropriate container environment. Note: DoesNOT update GitHub check status.

For guidance on mapping tests to stage names, seedocs/source/reference/ci-overview.md
and thescripts/test_to_stage_mapping.py helper.

kill

kill

Kill all running builds associated with pull request.

skip

skip --comment COMMENT

Skip testing for latest commit on pull request.--comment "Reason for skipping build/test" is required. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

reuse-pipeline

reuse-pipeline

Reuse a previous pipeline to validate current commit. This action will also kill all currently running builds associated with the pull request. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

Pin numpy version for Gemma.

db02a4e

Signed-off-by: Yuxian Qiu <142763828+yuxianq@users.noreply.github.com>

yuxianq requested review fromQiJune,Superjomn andchzblych

September 17, 2025 04:42

yuxianq requested a review froma team as acode owner

September 17, 2025 04:42

Copy link

Contributor

coderabbitaibot commentedSep 17, 2025•
edited
Loading

📝 Walkthrough

Walkthrough

Adds numpy<2 to the Gemma example’s requirements and simplifies integration test setup by replacing platform-specific dependency installation with a single pip install -r against the example’s requirements file.

Changes

Cohort / File(s)	Summary
Gemma example requirements `examples/models/core/gemma/requirements.txt`	Constrains numpy version with`numpy<2` added after`flax~=0.8.0`.
Integration test setup simplification `tests/integration/defs/conftest.py`	Replaces OS/arch-specific package installs (jax/jaxlib, CUDA handling, safetensors, nltk, flax, cuDNN constraints) with`pip install -r <gemma_path>/requirements.txt`; function signatures unchanged.

Sequence Diagram(s)

sequenceDiagram    participant Pytest as Pytest    participant Conftest as conftest.py    participant Pip as pip    participant GemmaReq as gemma/requirements.txt    Pytest->>Conftest: call gemma_example_root()    Note over Conftest: Setup dependencies for Gemma example    Conftest->>Pip: pip install -r <gemma_path>/requirements.txt    Pip->>GemmaReq: Read dependency list    Pip-->>Conftest: Install per manifest (incl. numpy<2)    Conftest-->>Pytest: Return gemma example root path

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

✨ Finishing touches

📝 Generate Docstrings

🧪 Generate unit tests

Create PR with unit tests
Post copyable unit tests in a comment

Tip

👮 Agentic pre-merge checks are now available in preview!

Pro plan users can now enable pre-merge checks in their settings to enforce checklists before merging PRs.

Built-in checks – Quickly apply ready-made checks to enforce title conventions, require pull request descriptions that follow templates, validate linked issues for compliance, and more.
Custom agentic checks – Define your own rules using CodeRabbit’s advanced agentic capabilities to enforce organization-specific policies and workflows. For example, you can instruct CodeRabbit’s agent to verify that API documentation is updated whenever API schema files are modified in a PR. Note: Upto 5 custom checks are currently allowed during the preview period. Pricing for this feature will be announced in a few weeks.

Please see thedocumentation for more information.

Example:

reviews:pre_merge_checks:custom_checks:      -name:"Undocumented Breaking Changes"mode:"warning"instructions:|          Pass/fail criteria: All breaking changes to public APIs, CLI flags, environment variables, configuration keys, database schemas, or HTTP/GraphQL endpoints must be documented in the "Breaking Change" section of the PR description and in CHANGELOG.md. Exclude purely internal or private changes (e.g., code not exported from package entry points or explicitly marked as internal).

Please share your feedback with us on thisDiscord post.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment@coderabbitai help to get the list of available commands and usage tips.}

Pre-merge checks

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Description Check	⚠️ Warning	The PR body contains only the repository PR template and an@coderabbitai marker but is not filled out: there is no completed title following the required template, no concise "Description" explaining what and why, no "Test Coverage" listing relevant tests or CI stages, and the PR checklist items are not addressed; while the pr_objectives/raw_summary show the intent to pin numpy<2 and simplify gemma dependency installation, those concrete details are absent from the author-provided description.	Please update the PR to include a title that follows the repository template, add a concise Description stating the exact changes and rationale (e.g., pin numpy<2 in examples/models/core/gemma/requirements.txt and replace platform-specific installs with pip -r in tests/integration/defs/conftest.py), add a Test Coverage section naming tests or CI stages that validate the change, and complete the PR Checklist items (dependency scan, CODEOWNERS, docs) before requesting review and running CI.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Title Check	✅ Passed	The title "[https://nvbugs/5522332][fix] Pin numpy version for Gemma." is concise, follows the repository ticket/type pattern, and accurately summarizes the primary change (adding a numpy<2 constraint to the Gemma example requirements), so it clearly communicates the main intent of the PR.
Docstring Coverage	✅ Passed	Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.

yuxianq changed the title~~Pin numpy version for Gemma.~~[https://nvbugs/5522332][fix] Pin numpy version for Gemma.

Sep 17, 2025

Copy link

CollaboratorAuthor

yuxianq commentedSep 17, 2025

/bot run --disable-fail-fast

Copy link

Collaborator

tensorrt-cicd commentedSep 17, 2025

PR_Github #18891 [ run ] triggered by Bot

coderabbitaibot reviewed

Sep 17, 2025

View reviewed changes

Copy link

Contributor

coderabbitaibot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (3)

examples/models/core/gemma/requirements.txt (1)
8-8:Add a brief rationale comment to prevent future churn.
Add a one‑liner explaining why NumPy is pinned and when to revisit.
Apply:
 flax~=0.8.0+# Pin NumPy <2 due to Gemma’s JAX/Flax stack on release/1.0; revisit when upgrading JAX/Flax. numpy<2
tests/integration/defs/conftest.py (2)
283-287:Guard against cross-test env contamination (optional teardown).
Installing example-specific deps (now includingnumpy<2) can affect later tests sharing the same venv. Consider restoring root deps after Gemma tests, as done formamba/recurrentgemma.
Apply:
 @pytest.fixture(scope="module") def gemma_example_root(llm_root, llm_venv):     "Get gemma example root"     example_root = os.path.join(llm_root, "examples", "models", "core", "gemma")-    llm_venv.run_cmd([-        "-m", "pip", "install", "-r",-        os.path.join(example_root, "requirements.txt")-    ])--    return example_root+    llm_venv.run_cmd([+        "-m", "pip", "install", "-r",+        os.path.join(example_root, "requirements.txt")+    ])+    try:+        yield example_root+    finally:+        # Restore base deps to avoid leakage into subsequent tests+        llm_venv.run_cmd([+            "-m", "pip", "install", "-r",+            os.path.join(llm_root, "requirements.txt")+        ])
1-16:Update copyright year.
File changed in 2025; header should include 2025 per guidelines.
Apply:
-# SPDX-FileCopyrightText: Copyright (c) 2022-2024 NVIDIA CORPORATION & AFFILIATES. All rights reserved.+# SPDX-FileCopyrightText: Copyright (c) 2022-2025 NVIDIA CORPORATION & AFFILIATES. All rights reserved.

📜 Review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between2d7af4b anddb02a4e.

📒 Files selected for processing (2)

examples/models/core/gemma/requirements.txt (1 hunks)
tests/integration/defs/conftest.py (1 hunks)

🧰 Additional context used

📓 Path-based instructions (3)

**/*.{h,hpp,hh,hxx,cpp,cxx,cc,cu,cuh,py}

📄 CodeRabbit inference engine (CODING_GUIDELINES.md)

Use only spaces, no tabs; indent with 4 spaces.

Files:

tests/integration/defs/conftest.py

**/*.py

📄 CodeRabbit inference engine (CODING_GUIDELINES.md)

**/*.py: Python code must target Python 3.8+.
Indent Python code with 4 spaces; do not use tabs.
Maintain module namespace when importing; prefer 'from package.subpackage import foo' then 'foo.SomeClass()' instead of importing the class directly.
Python filenames should be snake_case (e.g., some_file.py).
Python classes use PascalCase names.
Functions and methods use snake_case names.
Local variables use snake_case; prefix 'k' for variables that start with a number (e.g., k_99th_percentile).
Global variables use upper SNAKE_CASE prefixed with 'G' (e.g., G_MY_GLOBAL).
Constants use upper SNAKE_CASE (e.g., MY_CONSTANT).
Avoid shadowing variables from an outer scope.
Initialize all externally visible members of a class in the constructor.
Prefer docstrings for interfaces that may be used outside a file; comments for in-function or file-local interfaces.
Use Google-style docstrings for classes and functions (Sphinx-parsable).
Document attributes and variables inline so they render under the class/function docstring.
Avoid reflection when a simpler, explicit approach suffices (e.g., avoid dict(**locals()) patterns).
In try/except, catch the most specific exceptions possible.
For duck-typing try/except, keep the try body minimal and use else for the main logic.

Files:

tests/integration/defs/conftest.py

**/*.{cpp,cxx,cc,h,hpp,hh,hxx,cu,cuh,py}

📄 CodeRabbit inference engine (CODING_GUIDELINES.md)

Prepend the NVIDIA Apache-2.0 copyright header with current year to the top of all source files (e.g., .cpp, .h, .cu, .py).

Files:

tests/integration/defs/conftest.py

🧠 Learnings (1)

📚 Learning: 2025-08-01T15:14:45.673Z

Learnt from: yibinl-nvidiaPR: NVIDIA/TensorRT-LLM#6506File: examples/models/core/mixtral/requirements.txt:3-3Timestamp: 2025-08-01T15:14:45.673ZLearning: In TensorRT-LLM, examples directory can have different dependency versions than the root requirements.txt file. Version conflicts between root and examples dependencies are acceptable because examples are designed to be standalone and self-contained.

Applied to files:

tests/integration/defs/conftest.py

🧬 Code graph analysis (1)

tests/integration/defs/conftest.py (2)

tests/integration/defs/perf/utils.py (2)
run_cmd (112-172)
run_cmd (209-287)
tests/integration/defs/triton_server/local_venv.py (1)
run_cmd (95-107)

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)

GitHub Check: Pre-commit Check

🔇 Additional comments (2)

tests/integration/defs/conftest.py (1)
283-287:Good simplification: install via the example’s requirements.
Aligns Gemma with other examples usingpip install -r. LGTM.
examples/models/core/gemma/requirements.txt (1)
8-8:Approve — NumPy<2 pin OK; constraints & CI verified
-c ../../../constraints.txt resolves to examples/constraints.txt; neither that file nor top-level constraints.txt contains a numpy pin (no >=2).
Repo already pins numpy<2 in requirements.txt and tests/integration/defs/perf/requirements.txt.
CI: .github/workflows/precommit-check.yml uses python-version '3.12'; .github/workflows/label_community_pr.yml uses '3.x' (no explicit 3.13).

chzblych approved these changes

Sep 17, 2025

View reviewed changes

chzblych added the Release BlockerPRs that blocking the final release build or branching out the release branch label

Sep 17, 2025

moraxu self-assigned this

Sep 17, 2025

Copy link

Collaborator

tensorrt-cicd commentedSep 17, 2025

PR_Github #18891 [ run ] completed with stateSUCCESS
/LLM/release-1.0/L0_MergeRequest_PR pipeline #405 completed with status: 'SUCCESS'

yuxianq merged commita838c2c intoNVIDIA:release/1.0

Sep 17, 2025

5 of 6 checks passed

coderabbitaibot mentioned this pull request

Sep 17, 2025

[https://nvbugs/5522332][fix] Pin numpy version for Gemma. (cherry-pick https://github.com/NVIDIA/TensorRT-LLM/pull/7783)#7797

Merged

1 task

dominicshanshan pushed a commit to dominicshanshan/TensorRT-LLM that referenced this pull request

Sep 17, 2025

[https://nvbugs/5522332][fix] Pin numpy version for Gemma. (NVIDIA#7783)

a474bb1

Signed-off-by: Yuxian Qiu <142763828+yuxianq@users.noreply.github.com>

dominicshanshan pushed a commit to dominicshanshan/TensorRT-LLM that referenced this pull request

Sep 17, 2025

[https://nvbugs/5522332][fix] Pin numpy version for Gemma. (NVIDIA#7783)

53a7458

Signed-off-by: Yuxian Qiu <142763828+yuxianq@users.noreply.github.com>

dominicshanshan pushed a commit to dominicshanshan/TensorRT-LLM that referenced this pull request

Sep 18, 2025

[https://nvbugs/5522332][fix] Pin numpy version for Gemma. (NVIDIA#7783)

9aa5339

Signed-off-by: Yuxian Qiu <142763828+yuxianq@users.noreply.github.com>

dominicshanshan pushed a commit to dominicshanshan/TensorRT-LLM that referenced this pull request

Sep 18, 2025

[https://nvbugs/5522332][fix] Pin numpy version for Gemma. (NVIDIA#7783)

79e356b

Signed-off-by: Yuxian Qiu <142763828+yuxianq@users.noreply.github.com>

dominicshanshan pushed a commit to dominicshanshan/TensorRT-LLM that referenced this pull request

Sep 18, 2025

[https://nvbugs/5522332][fix] Pin numpy version for Gemma. (NVIDIA#7783)

8526c87

Signed-off-by: Yuxian Qiu <142763828+yuxianq@users.noreply.github.com>

dominicshanshan pushed a commit to dominicshanshan/TensorRT-LLM that referenced this pull request

Sep 19, 2025

[https://nvbugs/5522332][fix] Pin numpy version for Gemma. (NVIDIA#7783)

76476a7

Signed-off-by: Yuxian Qiu <142763828+yuxianq@users.noreply.github.com>

dominicshanshan pushed a commit to dominicshanshan/TensorRT-LLM that referenced this pull request

Sep 19, 2025

[https://nvbugs/5522332][fix] Pin numpy version for Gemma. (NVIDIA#7783)

e7c1a4b

Signed-off-by: Yuxian Qiu <142763828+yuxianq@users.noreply.github.com>Signed-off-by: Wangshanshan <30051912+dominicshanshan@users.noreply.github.com>

yuxianq added a commit that referenced this pull request

Sep 19, 2025

[https://nvbugs/5522332][fix] Pin numpy version for Gemma. (cherry-pick

7d28acd

#7783) (#7797)Signed-off-by: Yuxian Qiu <142763828+yuxianq@users.noreply.github.com>

dominicshanshan pushed a commit to dominicshanshan/TensorRT-LLM that referenced this pull request

Sep 19, 2025

[https://nvbugs/5522332][fix] Pin numpy version for Gemma. (NVIDIA#7783)

061a5c5

Signed-off-by: Yuxian Qiu <142763828+yuxianq@users.noreply.github.com>Signed-off-by: Wangshanshan <30051912+dominicshanshan@users.noreply.github.com>

dominicshanshan pushed a commit to dominicshanshan/TensorRT-LLM that referenced this pull request

Sep 19, 2025

[https://nvbugs/5522332][fix] Pin numpy version for Gemma. (NVIDIA#7783)

564027b

Signed-off-by: Yuxian Qiu <142763828+yuxianq@users.noreply.github.com>Signed-off-by: Wangshanshan <30051912+dominicshanshan@users.noreply.github.com>

Wong4j pushed a commit to Wong4j/TensorRT-LLM that referenced this pull request

Sep 20, 2025

[https://nvbugs/5522332][fix] Pin numpy version for Gemma. (cherry-pick

b90cc01

NVIDIA#7783) (NVIDIA#7797)Signed-off-by: Yuxian Qiu <142763828+yuxianq@users.noreply.github.com>

MrGeva pushed a commit to nv-auto-deploy/TensorRT-LLM that referenced this pull request

Sep 21, 2025

[https://nvbugs/5522332][fix] Pin numpy version for Gemma. (cherry-pick

bf012c8

NVIDIA#7783) (NVIDIA#7797)Signed-off-by: Yuxian Qiu <142763828+yuxianq@users.noreply.github.com>

Labels

Release Blocker

PRs that blocking the final release build or branching out the release branch

Movatterモバイル変換

[https://nvbugs/5522332][fix] Pin numpy version for Gemma.#7783

[https://nvbugs/5522332][fix] Pin numpy version for Gemma.#7783

Uh oh!

Conversation

yuxianq commentedSep 17, 2025• editedLoading Uh oh!There was an error while loading.Please reload this page.

Uh oh!

Summary by CodeRabbit

Description

Test Coverage

PR Checklist

GitHub Bot Help

kill

skip

reuse-pipeline

Uh oh!

coderabbitaibot commentedSep 17, 2025• editedLoading Uh oh!There was an error while loading.Please reload this page.

Uh oh!

Walkthrough

Changes

Sequence Diagram(s)

Estimated code review effort

Pre-merge checks

Uh oh!

yuxianq commentedSep 17, 2025

Uh oh!

tensorrt-cicd commentedSep 17, 2025

Uh oh!

coderabbitaibot left a comment

Choose a reason for hiding this comment

Uh oh!

tensorrt-cicd commentedSep 17, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

yuxianq commentedSep 17, 2025•
edited
Loading

coderabbitaibot commentedSep 17, 2025•
edited
Loading