- Notifications
You must be signed in to change notification settings - Fork1.9k
[None][fix] fix CUDA graph config for test_llm_api_pytorch.py.#6826
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
Signed-off-by: Yuxian Qiu <142763828+yuxianq@users.noreply.github.com>
coderabbitaibot commentedAug 12, 2025 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
📝 WalkthroughWalkthroughReplaced use_cuda_graph boolean parameters with cuda_graph_config objects in LLM initialization within tests/integration/defs/accuracy/test_llm_api_pytorch.py. Calls now pass cuda_graph_config=CudaGraphConfig() when enabled, else None. No assertions changed. Public API updated: LLM.init now accepts Optional[CudaGraphConfig] instead of use_cuda_graph: bool. Changes
Sequence Diagram(s)sequenceDiagram participant Test as Test (PyTorch accuracy) participant LLM as LLM.__init__ participant CG as CudaGraphConfig Test->>LLM: __init__(..., cuda_graph_config = CudaGraphConfig() or None) alt cuda_graph enabled LLM->>CG: Use default CUDA Graph settings LLM-->>Test: LLM instance with CUDA Graph configured else disabled LLM-->>Test: LLM instance without CUDA Graph endEstimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes Possibly related PRs
Suggested reviewers
📜 Recent review detailsConfiguration used: .coderabbit.yaml 📒 Files selected for processing (1)
🧰 Additional context used📓 Path-based instructions (2)**/*.py📄 CodeRabbit Inference Engine (CODING_GUIDELINES.md)
Files:
**/*.{cpp,cxx,cc,cu,h,hpp,hxx,hh,cuh,py}📄 CodeRabbit Inference Engine (CODING_GUIDELINES.md)
Files:
🔇 Additional comments (4)
✨ Finishing Touches
🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat withCodeRabbit:
SupportNeed help? Create a ticket on oursupport page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR/Issue comments)Type Other keywords and placeholders
Status, Documentation and Community
|
yuxianq commentedAug 12, 2025
/bot run |
tensorrt-cicd commentedAug 12, 2025
PR_Github #14960 [ run ] triggered by Bot |
QiJune left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
LGTM
crazydemo left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
LGTM
tensorrt-cicd commentedAug 12, 2025
PR_Github #14960 [ run ] completed with state |
cf00003 intoNVIDIA:release/1.0Uh oh!
There was an error while loading.Please reload this page.
…A#6826)Signed-off-by: Yuxian Qiu <142763828+yuxianq@users.noreply.github.com>
…A#6826)Signed-off-by: Yuxian Qiu <142763828+yuxianq@users.noreply.github.com>Signed-off-by: Wangshanshan <30051912+dominicshanshan@users.noreply.github.com>
…A#6826)Signed-off-by: Yuxian Qiu <142763828+yuxianq@users.noreply.github.com>Run pre-commit.Signed-off-by: Wangshanshan <30051912+dominicshanshan@users.noreply.github.com>
…A#6826)Signed-off-by: Yuxian Qiu <142763828+yuxianq@users.noreply.github.com>Run pre-commit.Signed-off-by: Wangshanshan <30051912+dominicshanshan@users.noreply.github.com>
…A#6826)Signed-off-by: Yuxian Qiu <142763828+yuxianq@users.noreply.github.com>Run pre-commit.Signed-off-by: Wangshanshan <30051912+dominicshanshan@users.noreply.github.com>
…A#6826)Signed-off-by: Yuxian Qiu <142763828+yuxianq@users.noreply.github.com>
…A#6826)Signed-off-by: Yuxian Qiu <142763828+yuxianq@users.noreply.github.com>Signed-off-by: Wangshanshan <30051912+dominicshanshan@users.noreply.github.com>
…A#6826)Signed-off-by: Yuxian Qiu <142763828+yuxianq@users.noreply.github.com>
…A#6826)Signed-off-by: Yuxian Qiu <142763828+yuxianq@users.noreply.github.com>Signed-off-by: Wangshanshan <30051912+dominicshanshan@users.noreply.github.com>
…A#6826)Signed-off-by: Yuxian Qiu <142763828+yuxianq@users.noreply.github.com>
…A#6826)Signed-off-by: Yuxian Qiu <142763828+yuxianq@users.noreply.github.com>Signed-off-by: Wangshanshan <30051912+dominicshanshan@users.noreply.github.com>
…A#6826)Signed-off-by: Yuxian Qiu <142763828+yuxianq@users.noreply.github.com>Signed-off-by: Wangshanshan <30051912+dominicshanshan@users.noreply.github.com>
…A#6826)Signed-off-by: Yuxian Qiu <142763828+yuxianq@users.noreply.github.com>
…A#6826)Signed-off-by: Yuxian Qiu <142763828+yuxianq@users.noreply.github.com>Signed-off-by: Wangshanshan <30051912+dominicshanshan@users.noreply.github.com>
…A#6826)Signed-off-by: Yuxian Qiu <142763828+yuxianq@users.noreply.github.com>Signed-off-by: Wangshanshan <30051912+dominicshanshan@users.noreply.github.com>
…A#6826)Signed-off-by: Yuxian Qiu <142763828+yuxianq@users.noreply.github.com>Signed-off-by: Wangshanshan <30051912+dominicshanshan@users.noreply.github.com>
…A#6826)Signed-off-by: Yuxian Qiu <142763828+yuxianq@users.noreply.github.com>Signed-off-by: Wangshanshan <30051912+dominicshanshan@users.noreply.github.com>
Uh oh!
There was an error while loading.Please reload this page.
Summary by CodeRabbit
Refactor
Tests
Description
Test Coverage
GitHub Bot Help
/bot [-h] ['run', 'kill', 'skip', 'reuse-pipeline'] ...Provide a user friendly way for developers to interact with a Jenkins server.
Run
/bot [-h|--help]to print this help message.See details below for each supported subcommand.
run [--reuse-test (optional)pipeline-id --disable-fail-fast --skip-test --stage-list "A10-PyTorch-1, xxx" --gpu-type "A30, H100_PCIe" --test-backend "pytorch, cpp" --add-multi-gpu-test --only-multi-gpu-test --disable-multi-gpu-test --post-merge --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx" --detailed-log --debug(experimental)]Launch build/test pipelines. All previously running jobs will be killed.
--reuse-test (optional)pipeline-id(OPTIONAL) : Allow the new pipeline to reuse build artifacts and skip successful test stages from a specified pipeline or the last pipeline if no pipeline-id is indicated. If the Git commit ID has changed, this option will be always ignored. The DEFAULT behavior of the bot is to reuse build artifacts and successful test results from the last pipeline.--disable-reuse-test(OPTIONAL) : Explicitly prevent the pipeline from reusing build artifacts and skipping successful test stages from a previous pipeline. Ensure that all builds and tests are run regardless of previous successes.--disable-fail-fast(OPTIONAL) : Disable fail fast on build/tests/infra failures.--skip-test(OPTIONAL) : Skip all test stages, but still run build stages, package stages and sanity check stages. Note: DoesNOT update GitHub check status.--stage-list "A10-PyTorch-1, xxx"(OPTIONAL) : Only run the specified test stages. Examples: "A10-PyTorch-1, xxx". Note: DoesNOT update GitHub check status.--gpu-type "A30, H100_PCIe"(OPTIONAL) : Only run the test stages on the specified GPU types. Examples: "A30, H100_PCIe". Note: DoesNOT update GitHub check status.--test-backend "pytorch, cpp"(OPTIONAL) : Skip test stages which don't match the specified backends. Only support [pytorch, cpp, tensorrt, triton]. Examples: "pytorch, cpp" (does not run test stages with tensorrt or triton backend). Note: DoesNOT update GitHub pipeline status.--only-multi-gpu-test(OPTIONAL) : Only run the multi-GPU tests. Note: DoesNOT update GitHub check status.--disable-multi-gpu-test(OPTIONAL) : Disable the multi-GPU tests. Note: DoesNOT update GitHub check status.--add-multi-gpu-test(OPTIONAL) : Force run the multi-GPU tests in addition to running L0 pre-merge pipeline.--post-merge(OPTIONAL) : Run the L0 post-merge pipeline instead of the ordinary L0 pre-merge pipeline.--extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx"(OPTIONAL) : Run the ordinary L0 pre-merge pipeline and specified test stages. Examples: --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx".--detailed-log(OPTIONAL) : Enable flushing out all logs to the Jenkins console. This will significantly increase the log volume and may slow down the job.--debug(OPTIONAL) :Experimental feature. Enable access to the CI container for debugging purpose. Note: Specify exactly one stage in thestage-listparameter to access the appropriate container environment. Note: DoesNOT update GitHub check status.For guidance on mapping tests to stage names, see
docs/source/reference/ci-overview.mdand the
scripts/test_to_stage_mapping.pyhelper.kill
killKill all running builds associated with pull request.
skip
skip --comment COMMENTSkip testing for latest commit on pull request.
--comment "Reason for skipping build/test"is required. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.reuse-pipeline
reuse-pipelineReuse a previous pipeline to validate current commit. This action will also kill all currently running builds associated with the pull request. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.