Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

fix(module: textarea-item) fix ngModel#887

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
sharky559 wants to merge1 commit intoNG-ZORRO:master
base:master
Choose a base branch
Loading
fromsharky559:fix-textarea-item

Conversation

sharky559
Copy link

@sharky559sharky559 commentedJul 20, 2023•
edited
Loading

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix[ ] Feature[ ] Code style update (formatting, local variables)[ ] Refactoring (no functional changes, no api changes)[ ] Build related changes[ ] CI related changes[ ] Documentation content changes[ ] Application (the showcase website) / infrastructure changes[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

When a textarea is entered with a value, this._onChange is triggered in both of the following places, which causes the value of the form control to be triggered twice, leading to a number of problems
image

image

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes[x] No

Other information

@sharky559sharky559 marked this pull request as draftJuly 20, 2023 09:04
@sharky559sharky559 marked this pull request as ready for reviewJuly 20, 2023 09:04
@aijunhao
Copy link
Collaborator

I'm sorry, I can't reproduce the problem you mentioned. Can you give me a demo on StackBlitz?

@sharky559
Copy link
Author

I'm sorry, I can't reproduce the problem you mentioned. Can you give me a demo on StackBlitz?

When the value of the textarea input changes, you can see that the ngModelChange method is triggered twice, which doesn't look quite normal.
https://stackblitz.com/edit/angular-hrkf1c?file=src%2Fapp%2Fapp.component.ts

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@sharky559@aijunhao
[8]ページ先頭
©2009-2025 Movatter.jp