- Notifications
You must be signed in to change notification settings - Fork24
Add some tests for interestingness scripts.#50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Add some tests for interestingness scripts.#50
Uh oh!
There was an error while loading.Please reload this page.
Conversation
These are ported fromMozillaSecurity#36.
since dir is a shell function on Windows.
codecov-io commentedAug 29, 2017 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Codecov Report
@@ Coverage Diff @@## master #50 +/- ##==========================================+ Coverage 73.7% 83.01% +9.31%========================================== Files 13 13 Lines 1559 1666 +107 ==========================================+ Hits 1149 1383 +234+ Misses 410 283 -127
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Thanks for implementing the changes we discussed early on over IRC!
Only some nits to take care of now, so r+
| msg="CRASHED (Address Sanitizer fault)" | ||
| sta=CRASHED | ||
| elifreturn_code>0: | ||
| elif0<return_code<0x80000000: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Update the comment in theelse block that return_code can now be>= 0x80000000 in theelse block.
tests/test_lithium.py Outdated
| " if len(sys.argv) > 1" | ||
| " else os.listdir('.'))" | ||
| "]")] | ||
| sleep_cmd= [sys.executable,"-c","import time;time.sleep(3)"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Can we make sleep_cmd accept a variable timeout number, other than 3? I'm not really insistent on this though.
| winreg.KEY_QUERY_VALUE|winreg.KEY_SET_VALUE) | ||
| self.wer_disabled=bool(winreg.QueryValueEx(wer,"Disabled")[0]) | ||
| ifnotself.wer_disabled: | ||
| winreg.SetValueEx(wer,"Disabled",0,winreg.REG_DWORD,1) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
As discussed over IRC, let's add a comment that we are not sure if we are disabling reporting to Microsoft, or whether we are disabling crash report generation altogether.
These are ported from#36.