- Notifications
You must be signed in to change notification settings - Fork24
Add venv & interestingness tests#36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Add venv & interestingness tests#36
Uh oh!
There was an error while loading.Please reload this page.
Conversation
(passing in py2, failing in py3)Tests that setup.py works, and installed interestingness tests can be used in an installed environment.These are mostly ported to unittests from@nth10sd's work here:*MozillaSecurity#28*MozillaSecurity#33
This passes except for the fileIngredients unicode problems discussed in#33. |
Looks good so far, sans me nitpicking the |
Good call. We agreed to use platform.system() consistently. I'll push the update after#39 lands so the tests go green :-) |
The virtualenv test is failing on Travis due to system module differences. I'll have to investigate. |
In any case, use a python one-liner (sort-of) instead of type/cat.
codecov-io commentedAug 2, 2017
Codecov Report
@@ Coverage Diff @@## master #36 +/- ##===========================================+ Coverage 68.6% 80.87% +12.26%=========================================== Files 15 15 Lines 1497 1563 +66 ===========================================+ Hits 1027 1264 +237+ Misses 470 299 -171
Continue to review full report at Codecov.
|
I will split this into separate PRs, since the interestingness tests are much simpler. |
These are ported fromMozillaSecurity#36.
This adds tests to make sure setup.py doesn't break, and that interesting tests work as expected.
Calling LithiumTests.test_arithmetic in the venv also ensures that we can call interestingness scripts by path (not part of the lithium module).
This is a cleanup of some of the travis/appveyor tests@nth10sd came up with in#28 ! by porting them to unittests.