- Notifications
You must be signed in to change notification settings - Fork112
Remove shellify#184
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Remove shellify#184
Uh oh!
There was an error while loading.Please reload this page.
Conversation
… shellescape PyPI library instead.
Due to test failures, I will have to split off |
codecov-io commentedApr 20, 2018 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Codecov Report
@@ Coverage Diff @@## master #184 +/- ##========================================= Coverage ? 20.54% ========================================= Files ? 27 Lines ? 2565 Branches ? 0 ========================================= Hits ? 527 Misses ? 2038 Partials ? 0
Continue to review full report at Codecov.
|
This latest build failure is unrelated. During the process, mozilla-centralupgraded its minimium Python requirement to be 3.5+ (seebug 1451065). All the checkspass at the previous ec0a3a1 changeset here. |
src/funfuzz/js/compare_jit.py Outdated
| anyLineContains(r.err,"[scriptfile] [scriptarg...]"))): | ||
| print("Got usage error from:") | ||
| print(" %s"%sps.shellify(command)) | ||
| print(" %s"%" ".join([quote(x)forxincommand])) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Don't usestr.join([list comprehension]), usestr.join(generator expression) instead.
List comprehension builds the whole list in-memory and then callsjoin() on the result. A generator expression works as though each item is yielded tojoin() as it is evaluated. The syntax is the same, just drop the square brackets.
This occurs on nearly every line changed, so I haven't added comments on them all.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
lgtm
Uh oh!
There was an error while loading.Please reload this page.
pathlib2from PyPI (orpathlibvia the Python 3.5+ stdlib) andgetAbsPathForAdjacentFile,normExpUserPathandshellifydo not have tests.This PR
starts us off the route for usingcompletely removespathlib2/pathlibin our tests first, andshellify.Fixes#183.