- Notifications
You must be signed in to change notification settings - Fork13.2k
Add code fix to remove unused label#24037
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
| function doChange(changes: textChanges.ChangeTracker, sourceFile: SourceFile, start: number): void { | ||
| const token = getTokenAtPosition(sourceFile, start, /*includeJsDocComment*/ false); | ||
| const statement = cast(token.parent, isLabeledStatement).statement; | ||
| changes.deleteRange(sourceFile, { pos: token.getStart(sourceFile), end: statement.getStart(sourceFile) }); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
this will remove comments on the statement before the label.. if you are deleting a range, why not just delete from token.pos to:.end?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I wanted to remove the space between the: and the statement following it.token.getStart should not include any comments precedingtoken. (Buttoken.pos would.)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
/*not deleted*/ label /*deleted*/ : /*deleted*/ call();?
amcasey left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I have concerns about the trivia, but I understand you're tracking that as its own (increasingly expensive) work item. Otherwise, LGTM.
| function doChange(changes: textChanges.ChangeTracker, sourceFile: SourceFile, start: number): void { | ||
| const token = getTokenAtPosition(sourceFile, start, /*includeJsDocComment*/ false); | ||
| const statement = cast(token.parent, isLabeledStatement).statement; | ||
| changes.deleteRange(sourceFile, { pos: token.getStart(sourceFile), end: statement.getStart(sourceFile) }); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
/*not deleted*/ label /*deleted*/ : /*deleted*/ call();?
| // @noUnusedLocals: true | ||
| ////label1: while (1) {} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
What happens for outdented labels on preceding lines?
label: codeDoes formatting restore the indentation? Otherwise, it seems like you'd end up withcode outdented.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Fixed.
Similar to#24028