- Notifications
You must be signed in to change notification settings - Fork13.2k
Add support for extended Unicode escape sequences in strings and templates#2169
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
DanielRosenwasser merged 16 commits intomasterfromwithANameLikeUnicodeYoudThinkThereWouldntBeSoManyWaysToDoItMar 3, 2015
Merged
Add support for extended Unicode escape sequences in strings and templates#2169
DanielRosenwasser merged 16 commits intomasterfromwithANameLikeUnicodeYoudThinkThereWouldntBeSoManyWaysToDoItMar 3, 2015
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
…in separate functions.
...because caps lock is cruise control for cool.
…eSoManyWaysToDoItConflicts:src/compiler/diagnosticInformationMap.generated.tssrc/compiler/diagnosticMessages.json
Contributor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
'Unterminated unicode escape'
DanielRosenwasser added a commit that referenced this pull requestMar 3, 2015
…ThereWouldntBeSoManyWaysToDoItAdd support for extended Unicode escape sequences in strings and templates
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes#2047.
ES6 extended escapes take the form of
\u{XXXXX...}whereXXXXX...is any number of hex digits.It is a syntax error if the value of these digits is greater than 0x10FFFF. When interpreting the value of such a code point, it must be interpreted as two individual UTF16 codepoints througha well-defined encoding scheme.Notable changes are:
\uXXXXescapes for any non-ASCII characters in the original string.\uXXXXescapes for any non-ASCII characters.Things we still don't support: