- Notifications
You must be signed in to change notification settings - Fork13.2k
Quick fix to correct qualified names to indexed access types#17462
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
aozgaa left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Not sure you want to make changes to get the fix working in the case mentioned below, but please add a test.
| consttoken=getTokenAtPosition(sourceFile,context.span.start,/*includeJsDocComment*/false); | ||
| constqualifiedName=getAncestor(token,SyntaxKind.QualifiedName)asQualifiedName; | ||
| Debug.assert(!!qualifiedName,"Expected position to be owned by a qualified name."); | ||
| if(!isIdentifier(qualifiedName.left)){ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
This example doesn't seem to trigger the right error, though we can apply the fix manually to fix the issue:
module M { export interface I { foo: string; }}let a: M.I.foo;Please add a test.
| @@ -1,3 +1,4 @@ | |||
| /// <reference path="correctQualifiedNameToIndexedAccessType.ts" /> | |||
| /// <reference path="fixClassIncorrectlyImplementsInterface.ts" /> | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Looks like there is an analogous entry to this insrc/harness/tsconfig.json. Not sure why it's there, or if we might want to remove it. Or alternatively, add a reference tocorrectQualifiedNameToIndexedAccessType.ts.
@weswigham do you know if building for tests will correctly trigger a rebuild when we make changes tocorrectQualifiedNameToIndexedAccessType.ts?
DanielRosenwasser commentedJul 27, 2017
…e already referenced in 'src/harness/codefixes/fixes.ts'.
Uh oh!
There was an error while loading.Please reload this page.
Fixes#17461