- Notifications
You must be signed in to change notification settings - Fork13.2k
Allow untyped imports#11889
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Allow untyped imports#11889
Uh oh!
There was an error while loading.Please reload this page.
Conversation
mhegazy left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
With changes to the error message
src/compiler/diagnosticMessages.json Outdated
| "category":"Error", | ||
| "code":6143 | ||
| }, | ||
| "A package for '{0}' was found at '{1}', but is untyped. Because '--noImplicitAny' is enabled, this package must have a declaration.": { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
how about something more consistent with the rest of the the--noImplicitAny error message, e.g.:Could not find a declaration file for module '{0}'. All imports implicitly have type 'any'.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
How about:"Could not find a declaration file for module '{0}'. '{1}' implicitly has an 'any' type."
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
👍
src/compiler/diagnosticMessages.json Outdated
| }, | ||
| "A package for '{0}' was found at '{1}', but is untyped. Because '--noImplicitAny' is enabled, this package must have a declaration.": { | ||
| "category":"Error", | ||
| "code":6144 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
make this error code in the7000 along with the other--noImplicitAnyErrors
Uh oh!
There was an error while loading.Please reload this page.
Fixes#11106
Replaces#11446
Made easier by#11704. No longer has to touch
moduleNameResolver.ts.