- Notifications
You must be signed in to change notification settings - Fork13.2k
Narrow string and number types in literal equality checks#11587
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
mhegazy approved these changesOct 13, 2016
zpdDG4gta8XKpMCd commentedOct 13, 2016
i am not at the computer to check, but would it fix#11433 as well? |
Contributor
mhegazy commentedOct 14, 2016
nope. that is a different issue. |
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
With this PR we narrow the
stringandnumbertypes as appropriate when they are compared with values of literal types.Interestingly this found abug in our scanner, pointing out that type
2is not comparable to type8.Fixes#7447.
Fixes#10417.
Fixes#11306.