- Notifications
You must be signed in to change notification settings - Fork5.4k
fix: layout inconsistencies 2 cp-13.12.0#38416
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Open
n3ps wants to merge1 commit intomainChoose a base branch
base:main
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
Open
+13 −122
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Contributor
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Collaborator
metamaskbot commentedNov 29, 2025 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
✨ Files requiring CODEOWNER review ✨👨🔧@MetaMask/core-extension-ux (6 files, +0 -105)
🔔@MetaMask/notifications (8 files, +12 -112)
|
Collaborator
metamaskbot commentedNov 29, 2025
Builds ready [2d4f075]
UI Startup Metrics (1212 ± 112 ms)
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
Description
Fixes layout inconsistencies in Notifcations and Permissions
Changelog
CHANGELOG entry: fix: layout inconsistencies
Related issues
Fixes:
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist
Note
Replaces the NotificationsPage wrapper with Page across notifications screens, updates page styles for sidepanel/snap, and routes Review Permissions via RootLayout.
NotificationsPageusage withPageinnotification-details,notifications-settings, andnotifications.ui/components/multichain/notifications-page/*(component, stories, tests) and its export fromui/components/multichain/index.js.data-testid="notifications-page"to<Page>.ui/components/multichain/pages/page/index.scss):.snap-view > .multichain-pageand.app--sidepanel .multichain-page.ui/pages/routes/routes.component.tsx):${REVIEW_PERMISSIONS}/:originlayout fromLegacyLayouttoRootLayout.Written byCursor Bugbot for commit2d4f075. This will update automatically on new commits. Configurehere.