MetaMask/metamask-extensionPublic

NotificationsYou must be signed in to change notification settings
Fork5.4k
Star13k

refactor: extract useEnableMissingNetwork into a separate hook#38412

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Draft

micaelae wants to merge1 commit intomain

base:main

Choose a base branch

fromswaps-refactor-useEnableMissingNetwork

Draft

refactor: extract useEnableMissingNetwork into a separate hook#38412

micaelae wants to merge1 commit intomainfromswaps-refactor-useEnableMissingNetwork

+134 −122

Conversation

Copy link

Member

micaelae commentedNov 28, 2025•
edited by github-actionsbot
Loading

Description

Changelog

CHANGELOG entry:

Related issues

Fixes:

Manual testing steps

Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

I've followedMetaMask Contributor Docs andMetaMask Extension Coding Standards.
I've completed the PR template to the best of my ability
I’ve included tests if applicable
I’ve documented my code usingJSDoc format if applicable
I’ve applied the right labels on the PR (seelabeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

refactor: extract useEnableMissingNetwork hook

24c81e4

metamaskbot added the team-swaps-and-bridgeSwaps and Bridge team label

Nov 28, 2025

Copy link

Collaborator

metamaskbot commentedNov 28, 2025

✨ Files requiring CODEOWNER review ✨

🔄@MetaMask/swaps-engineers (4 files, +134 -122)

📁 ui/
- 📁 pages/
  - 📁 bridge/
    - 📁 hooks/
      - 📄useEnableMissingNetwork.test.ts+76 -0
      - 📄useEnableMissingNetwork.ts+52 -0
    - 📁 prepare/
      - 📄prepare-bridge-page.test.tsx+1 -69
      - 📄prepare-bridge-page.tsx+5 -53

github-actionsbot added the size-M label

Nov 28, 2025

Copy link

Collaborator

metamaskbot commentedNov 28, 2025

Builds ready [24c81e4]

builds:chrome,firefox
builds (beta):chrome,firefox
builds (flask):chrome,firefox
builds (test):chrome,firefox
builds (test-flask):chrome,firefox
bundle size:Bundle Size Stats
user-actions-benchmark:User Actions Stats
storybook:Storybook
typescript migration:Dashboard
all artifacts
bundle viz:
- background:0,1,2,3,4,5,6,7,8,9
- common:0,1,2,3,4,5,6,7,8,9,10,11,12,13,14,15
- ui:0,1,2,3,4,5,6,7,8,9,10,11,12,13,14,15,16,17,18
- content-script:0
- offscreen:0

UI Startup Metrics (1245 ± 111 ms)

Platform	BuildType	Page	Metric	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P 75 (ms)	P 95 (ms)
Chrome	Browserify	Standard Home	uiStartup	1245	1047	1529	111	1320	1437
			load	1047	870	1278	94	1115	1215
			domContentLoaded	1041	866	1274	93	1110	1206
			domInteractive	25	15	104	18	22	79
			firstPaint	531	82	1261	409	1023	1203
			backgroundConnect	217	197	266	12	224	239
			firstReactRender	30	20	77	10	31	53
			getState	38	17	142	17	45	64
			initialActions	1	0	5	1	1	2
			loadScripts	830	664	1047	91	890	994
			setupStore	13	7	57	7	14	24
			numNetworkReqs	12	5	77	20	5	72
	Browserify	Power User Home	uiStartup	2063	1621	3162	282	2278	2599
			load	1009	877	1704	136	1004	1351
			domContentLoaded	994	872	1655	134	989	1345
			domInteractive	36	17	163	31	32	126
			firstPaint	606	92	1703	416	978	1340
			backgroundConnect	249	205	665	95	228	531
			firstReactRender	59	40	115	14	62	93
			getState	184	135	682	55	200	226
			initialActions	1	0	3	1	1	2
			loadScripts	789	676	1398	130	782	1140
			setupStore	19	9	43	6	22	31
			numNetworkReqs	165	64	413	77	203	381
	Webpack	Standard Home	uiStartup	857	713	1236	101	897	1042
			load	666	573	1066	94	697	853
			domContentLoaded	661	568	1059	93	692	848
			domInteractive	28	15	139	25	23	102
			firstPaint	214	85	809	131	216	606
			backgroundConnect	11	6	58	8	13	28
			firstReactRender	28	21	63	6	32	39
			getState	28	13	79	12	34	49
			initialActions	1	0	6	1	1	2
			loadScripts	658	566	1053	92	690	846
			setupStore	10	6	23	3	12	17
			numNetworkReqs	12	5	77	20	5	72
	Webpack	Power User Home	uiStartup	1615	1275	2730	262	1744	2117
			load	692	592	1030	100	698	947
			domContentLoaded	682	585	1025	101	689	941
			domInteractive	40	18	214	36	36	141
			firstPaint	266	92	981	173	271	673
			backgroundConnect	59	7	656	141	18	522
			firstReactRender	60	45	83	9	66	81
			getState	177	145	283	21	182	223
			initialActions	1	0	4	1	1	2
			loadScripts	679	583	1017	99	687	933
			setupStore	19	10	55	10	22	47
			numNetworkReqs	168	66	419	85	217	407
Firefox	Browserify	Standard Home	uiStartup	1320	1098	1847	141	1414	1587
			load	1082	950	1292	79	1133	1232
			domContentLoaded	1081	949	1292	79	1133	1232
			domInteractive	59	31	138	29	84	121
			firstPaint	-	-	-	-	-	-
			backgroundConnect	48	22	179	32	46	129
			firstReactRender	23	19	39	5	24	35
			getState	17	7	205	28	11	68
			initialActions	1	0	3	1	2	2
			loadScripts	1053	933	1222	72	1101	1189
			setupStore	15	6	167	22	14	58
			numNetworkReqs	11	5	64	16	6	61
	Browserify	Power User Home	uiStartup	2683	1968	4745	584	2718	4226
			load	1221	966	2632	299	1226	1612
			domContentLoaded	1221	966	2632	299	1226	1612
			domInteractive	116	33	637	101	119	353
			firstPaint	-	-	-	-	-	-
			backgroundConnect	139	20	1173	195	117	557
			firstReactRender	63	37	158	18	72	94
			getState	240	47	1063	197	245	762
			initialActions	2	0	7	1	2	3
			loadScripts	1169	946	2407	241	1190	1504
			setupStore	205	7	875	231	369	729
			numNetworkReqs	99	59	306	59	81	248
	Webpack	Standard Home	uiStartup	1532	1263	2060	154	1631	1843
			load	1255	1069	1475	101	1341	1438
			domContentLoaded	1254	1069	1475	101	1340	1437
			domInteractive	61	27	241	37	84	140
			firstPaint	-	-	-	-	-	-
			backgroundConnect	55	23	185	39	61	152
			firstReactRender	27	20	70	8	30	40
			getState	17	6	204	28	14	47
			initialActions	1	0	2	0	1	2
			loadScripts	1225	1052	1443	96	1303	1372
			setupStore	15	6	106	16	14	44
			numNetworkReqs	12	5	65	16	7	60
	Webpack	Power User Home	uiStartup	3057	2289	5050	696	3167	4862
			load	1472	1243	2881	338	1447	2630
			domContentLoaded	1472	1243	2880	338	1447	2630
			domInteractive	111	31	592	107	95	409
			firstPaint	-	-	-	-	-	-
			backgroundConnect	166	44	1146	205	146	535
			firstReactRender	74	42	222	30	78	146
			getState	318	79	1318	271	394	934
			initialActions	3	1	70	7	2	5
			loadScripts	1393	1201	2516	227	1382	1837
			setupStore	151	6	801	189	177	658
			numNetworkReqs	100	54	317	63	77	243

📊 Page Load Benchmark Results

Current Commit:24c81e4 |Date: 11/28/2025

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

pageLoadTime-> current mean value: 1.04s (±41ms) 🟡 | historical mean value: 1.04s ⬇️ (historical data)
domContentLoaded-> current mean value: 723ms (±38ms) 🟢 | historical mean value: 724ms ⬇️ (historical data)
firstContentfulPaint-> current mean value: 77ms (±12ms) 🟢 | historical mean value: 81ms ⬇️ (historical data)

📈 Detailed Results

Metric	Mean	Std Dev	Min	Max	P95	P99
pageLoadTime	1.04s	41ms	1.01s	1.35s	1.07s	1.35s
domContentLoaded	723ms	38ms	702ms	1.02s	753ms	1.02s
firstPaint	77ms	12ms	60ms	184ms	88ms	184ms
firstContentfulPaint	77ms	12ms	60ms	184ms	88ms	184ms
largestContentfulPaint	0ms	0ms	0ms	0ms	0ms	0ms

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 58 Bytes (0%)
ui: 527 Bytes (0.01%)
common: 20 Bytes (0%)

Labels

size-M team-swaps-and-bridge

Swaps and Bridge team

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

refactor: extract useEnableMissingNetwork into a separate hook#38412

Are you sure you want to change the base?

refactor: extract useEnableMissingNetwork into a separate hook#38412

Conversation

micaelae commentedNov 28, 2025•
edited by github-actionsbot
Loading

Uh oh!

Description

Changelog

Related issues

Manual testing steps