MetaMask/metamask-extensionPublic

NotificationsYou must be signed in to change notification settings
Fork5.4k
Star13k

test: migrate send-eth to POM#38402

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Draft

seaona wants to merge2 commits intomain

base:main

Choose a base branch

fromsend-eth-page-object

Draft

test: migrate send-eth to POM#38402

seaona wants to merge2 commits intomainfromsend-eth-page-object

+206 −201

Conversation

Copy link

Member

seaona commentedNov 28, 2025•
edited by github-actionsbot
Loading

Description

Changelog

CHANGELOG entry:

Related issues

Fixes:

Manual testing steps

Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

I've followedMetaMask Contributor Docs andMetaMask Extension Coding Standards.
I've completed the PR template to the best of my ability
I’ve included tests if applicable
I’ve documented my code usingJSDoc format if applicable
I’ve applied the right labels on the PR (seelabeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

draft

3935e81

metamaskbot added the team-qaQA team label

Nov 28, 2025

Copy link

Collaborator

metamaskbot commentedNov 28, 2025

✨ Files requiring CODEOWNER review ✨

🧪@MetaMask/qa (3 files, +53 -2)

📁 test/
- 📁 e2e/
  - 📁 page-objects/
    - 📁 flows/
      - 📄transaction.ts+1 -1
    - 📁 pages/
      - 📁 home/
        📄transaction-details.ts+11 -0
      - 📁 send/
        📄send-token-page.ts+41 -1

github-actionsbot added the size-M label

Nov 28, 2025

some fixes

72a08ed

Copy link

Collaborator

metamaskbot commentedNov 28, 2025

Builds ready [72a08ed]

builds:chrome,firefox
builds (beta):chrome,firefox
builds (flask):chrome,firefox
builds (test):chrome,firefox
builds (test-flask):chrome,firefox
bundle size:Bundle Size Stats
user-actions-benchmark:User Actions Stats
storybook:Storybook
typescript migration:Dashboard
all artifacts
bundle viz:
- background:0,1,2,3,4,5,6,7,8,9
- common:0,1,2,3,4,5,6,7,8,9,10,11,12,13,14,15
- ui:0,1,2,3,4,5,6,7,8,9,10,11,12,13,14,15,16,17,18
- content-script:0
- offscreen:0

UI Startup Metrics (1207 ± 122 ms)

Platform	BuildType	Page	Metric	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P 75 (ms)	P 95 (ms)
Chrome	Browserify	Standard Home	uiStartup	1207	929	1531	122	1310	1419
			load	1011	802	1310	102	1075	1190
			domContentLoaded	1004	799	1297	100	1067	1179
			domInteractive	25	14	88	19	20	80
			firstPaint	619	78	1317	406	1014	1185
			backgroundConnect	209	174	262	22	226	248
			firstReactRender	31	19	84	13	36	53
			getState	33	14	149	16	39	54
			initialActions	1	0	7	1	1	4
			loadScripts	802	620	1059	91	858	966
			setupStore	12	6	27	5	13	23
			numNetworkReqs	12	5	78	20	5	73
	Browserify	Power User Home	uiStartup	2084	1666	2892	281	2248	2657
			load	1018	884	1707	141	1018	1374
			domContentLoaded	1003	874	1699	142	1002	1359
			domInteractive	38	17	158	30	36	119
			firstPaint	661	108	1462	398	978	1357
			backgroundConnect	236	191	700	75	227	483
			firstReactRender	60	42	117	14	66	86
			getState	200	151	740	75	204	241
			initialActions	1	0	4	1	1	2
			loadScripts	798	679	1481	138	790	1153
			setupStore	18	10	58	7	20	34
			numNetworkReqs	146	66	425	80	203	288
	Webpack	Standard Home	uiStartup	822	691	1097	83	864	982
			load	637	553	899	72	669	790
			domContentLoaded	632	549	894	72	665	783
			domInteractive	28	15	162	27	22	96
			firstPaint	215	82	680	142	221	639
			backgroundConnect	10	5	62	7	9	24
			firstReactRender	28	19	81	9	32	39
			getState	24	13	46	8	30	39
			initialActions	1	0	4	1	1	2
			loadScripts	630	547	892	71	663	774
			setupStore	10	4	27	3	12	16
			numNetworkReqs	12	5	77	20	5	73
	Webpack	Power User Home	uiStartup	1639	1337	2711	273	1867	2126
			load	684	580	1250	102	686	950
			domContentLoaded	674	574	1243	103	672	944
			domInteractive	38	17	206	34	34	128
			firstPaint	282	99	1008	195	275	697
			backgroundConnect	43	8	562	107	19	387
			firstReactRender	61	44	125	11	66	77
			getState	186	137	696	76	184	231
			initialActions	1	0	5	1	1	2
			loadScripts	671	572	1232	101	670	935
			setupStore	21	10	57	11	24	45
			numNetworkReqs	167	67	411	82	220	383
Firefox	Browserify	Standard Home	uiStartup	1422	1121	2594	200	1513	1821
			load	1166	943	2284	154	1226	1384
			domContentLoaded	1166	943	2284	154	1225	1384
			domInteractive	83	34	1262	122	101	123
			firstPaint	-	-	-	-	-	-
			backgroundConnect	54	24	214	35	69	125
			firstReactRender	26	18	48	5	27	38
			getState	13	6	68	9	13	27
			initialActions	1	0	3	1	2	2
			loadScripts	1135	926	2259	149	1190	1292
			setupStore	15	7	121	16	13	32
			numNetworkReqs	12	5	70	17	6	62
	Browserify	Power User Home	uiStartup	2643	1926	4566	622	2773	4250
			load	1194	942	2565	347	1130	2456
			domContentLoaded	1193	936	2564	347	1129	2456
			domInteractive	115	34	532	107	106	418
			firstPaint	-	-	-	-	-	-
			backgroundConnect	143	25	1101	197	127	426
			firstReactRender	58	39	131	15	58	91
			getState	247	66	850	177	266	697
			initialActions	2	1	7	1	2	3
			loadScripts	1139	925	2371	272	1105	1507
			setupStore	164	10	785	194	177	698
			numNetworkReqs	101	60	249	59	80	241
	Webpack	Standard Home	uiStartup	1474	1229	1917	144	1520	1820
			load	1232	1068	1521	105	1295	1477
			domContentLoaded	1232	1068	1521	105	1295	1477
			domInteractive	57	29	202	34	78	113
			firstPaint	-	-	-	-	-	-
			backgroundConnect	47	18	174	29	49	113
			firstReactRender	26	20	72	7	28	38
			getState	13	6	162	17	12	27
			initialActions	1	0	3	1	2	2
			loadScripts	1205	1053	1496	97	1267	1403
			setupStore	13	6	99	13	13	37
			numNetworkReqs	12	5	67	17	7	65
	Webpack	Power User Home	uiStartup	2967	2167	4919	771	3002	4725
			load	1487	1172	3083	462	1602	2785
			domContentLoaded	1486	1171	3083	463	1602	2785
			domInteractive	110	32	512	112	95	452
			firstPaint	-	-	-	-	-	-
			backgroundConnect	136	36	982	148	152	486
			firstReactRender	67	38	321	40	63	183
			getState	336	63	1225	298	523	920
			initialActions	3	0	102	10	2	3
			loadScripts	1424	1133	3013	430	1474	2689
			setupStore	144	6	724	180	176	635
			numNetworkReqs	101	62	254	60	81	243

📊 Page Load Benchmark Results

Current Commit:72a08ed |Date: 11/28/2025

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

pageLoadTime-> current mean value: 1.06s (±38ms) 🟡 | historical mean value: 1.04s ⬆️ (historical data)
domContentLoaded-> current mean value: 743ms (±62ms) 🟢 | historical mean value: 723ms ⬆️ (historical data)
firstContentfulPaint-> current mean value: 83ms (±45ms) 🟢 | historical mean value: 79ms ⬆️ (historical data)

📈 Detailed Results

Metric	Mean	Std Dev	Min	Max	P95	P99
pageLoadTime	1.06s	38ms	1.03s	1.35s	1.09s	1.35s
domContentLoaded	743ms	62ms	709ms	1.31s	763ms	1.31s
firstPaint	83ms	45ms	64ms	524ms	92ms	524ms
firstContentfulPaint	83ms	45ms	64ms	524ms	92ms	524ms
largestContentfulPaint	0ms	0ms	0ms	0ms	0ms	0ms

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 896 Bytes (0.02%)
ui: 3.04 KiB (0.04%)
common: 684 Bytes (0.01%)

Labels

size-M team-qa

QA team

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

test: migrate send-eth to POM#38402

Are you sure you want to change the base?

test: migrate send-eth to POM#38402

Conversation

seaona commentedNov 28, 2025•
edited by github-actionsbot
Loading

Uh oh!

Description

Changelog

Related issues

Manual testing steps