Replace deprecated pre-releasereact-compiler/react-compiler ruleset withreact-hooks
Handle breaking changes from updating two major versions.
UseadditionalEffectHooks config field to applyreact-hooks/exhaustive-deps rule to custom hooksuseAsync{Callback,Result,ResultOrThrow}

Changelog

CHANGELOG entry:

Related issues

Fixes:

Manual testing steps

Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

I've followedMetaMask Contributor Docs andMetaMask Extension Coding Standards.
I've completed the PR template to the best of my ability
I’ve included tests if applicable
I’ve documented my code usingJSDoc format if applicable
I’ve applied the right labels on the PR (seelabeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Copy link

Contributor

github-actionsbot commentedNov 28, 2025

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

metamaskbot added the team-extension-platformExtension Platform team label

Nov 28, 2025

Copy link

socket-securitybot commentedNov 28, 2025•
edited
Loading

Review the following changes in direct dependencies. Learn more aboutSocket for GitHub.

Diff	Package	Supply Chain Security	Vulnerability	Quality	Maintenance	License
	eslint-plugin-react-hooks@5.2.0 ⏵ 7.0.1				⁺¹

View full report

github-actionsbot added the size-XS label

Nov 28, 2025

Copy link

ContributorAuthor

MajorLift commentedNov 28, 2025

@metamaskbot update-policies

Copy link

Collaborator

metamaskbot commentedNov 28, 2025

Policies updated.
👀 Please review the diff for suspicious new powers.

🧠 Learn how:https://lavamoat.github.io/guides/policy-diff/#what-to-look-for-when-reviewing-a-policy-diff

Copy link

Collaborator

metamaskbot commentedNov 28, 2025•
edited
Loading

✨ Files requiring CODEOWNER review ✨

🧩@MetaMask/extension-devs (1 files, +57 -1)

📁 lavamoat/
- 📁 build-system/
  - 📄policy.json+57 -1

📜@MetaMask/policy-reviewers (1 files, +57 -1)

📁 lavamoat/
- 📁 build-system/
  - 📄policy.json+57 -1

Tip

Follow the policy review process outlined in theLavaMoat Policy Review Process doc before expecting an approval from Policy Reviewers.

🔗@MetaMask/supply-chain (1 files, +57 -1)

📁 lavamoat/
- 📁 build-system/
  - 📄policy.json+57 -1

github-actionsbot added size-S and removed size-XS labels

Nov 28, 2025

MajorLift force-pushed thejongsun/chore/lint/bump-eslint-plugin-react-hooks-to-v7 branch from1c090f1 todf0041fCompare

November 28, 2025 13:10

Copy link

Collaborator

metamaskbot commentedNov 28, 2025

Builds ready [df0041f]

builds:chrome,firefox
builds (beta):chrome,firefox
builds (flask):chrome,firefox
builds (test):chrome,firefox
builds (test-flask):chrome,firefox
lavamoat build viz:Build System
bundle size:Bundle Size Stats
user-actions-benchmark:User Actions Stats
storybook:Storybook
typescript migration:Dashboard
all artifacts
bundle viz:
- background:0,1,2,3,4,5,6,7,8,9
- common:0,1,2,3,4,5,6,7,8,9,10,11,12,13,14,15
- ui:0,1,2,3,4,5,6,7,8,9,10,11,12,13,14,15,16,17,18
- content-script:0
- offscreen:0

UI Startup Metrics (1239 ± 122 ms)

Platform	BuildType	Page	Metric	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P 75 (ms)	P 95 (ms)
Chrome	Browserify	Standard Home	uiStartup	1239	1041	1571	122	1330	1458
			load	1038	861	1299	105	1107	1243
			domContentLoaded	1032	858	1293	103	1101	1234
			domInteractive	26	16	96	20	22	82
			firstPaint	533	93	1269	402	1002	1171
			backgroundConnect	212	191	269	12	217	235
			firstReactRender	31	21	62	9	36	54
			getState	38	16	118	19	45	83
			initialActions	1	0	11	1	1	3
			loadScripts	826	660	1087	100	895	1024
			setupStore	12	5	43	6	13	25
			numNetworkReqs	12	5	78	20	5	73
	Browserify	Power User Home	uiStartup	2062	1750	2674	223	2167	2537
			load	1033	908	1417	110	1024	1318
			domContentLoaded	1018	901	1404	109	1015	1311
			domInteractive	36	19	132	25	35	116
			firstPaint	559	132	1421	387	976	1281
			backgroundConnect	260	201	761	106	234	554
			firstReactRender	60	42	107	13	66	84
			getState	189	132	727	60	204	230
			initialActions	1	0	4	1	1	2
			loadScripts	807	697	1192	108	802	1103
			setupStore	21	10	76	11	24	46
			numNetworkReqs	102	66	273	50	95	259
	Webpack	Standard Home	uiStartup	808	699	1161	79	826	976
			load	626	563	904	66	649	787
			domContentLoaded	621	560	896	66	644	778
			domInteractive	26	15	125	21	22	78
			firstPaint	272	79	784	191	319	657
			backgroundConnect	10	5	72	8	10	19
			firstReactRender	27	20	45	6	31	38
			getState	27	13	72	11	35	47
			initialActions	1	0	3	1	1	1
			loadScripts	619	557	886	64	642	769
			setupStore	10	6	20	3	12	16
			numNetworkReqs	12	5	77	20	5	73
	Webpack	Power User Home	uiStartup	1673	1367	2599	271	1957	2183
			load	693	592	1241	112	696	967
			domContentLoaded	683	584	1234	112	692	957
			domInteractive	38	17	196	34	33	135
			firstPaint	276	96	929	185	273	687
			backgroundConnect	47	8	579	116	18	488
			firstReactRender	63	44	101	10	69	82
			getState	183	130	731	59	189	227
			initialActions	1	0	4	1	1	2
			loadScripts	680	582	1225	110	690	948
			setupStore	22	10	70	12	24	48
			numNetworkReqs	168	67	427	84	219	415
Firefox	Browserify	Standard Home	uiStartup	1292	1040	1880	180	1405	1725
			load	1058	897	1377	110	1137	1276
			domContentLoaded	1057	896	1377	110	1137	1276
			domInteractive	55	31	131	29	69	114
			firstPaint	-	-	-	-	-	-
			backgroundConnect	46	21	256	41	42	149
			firstReactRender	25	18	54	8	25	45
			getState	12	7	89	11	10	20
			initialActions	1	0	3	1	1	2
			loadScripts	1027	881	1328	94	1097	1217
			setupStore	21	6	249	43	11	146
			numNetworkReqs	11	5	68	16	6	62
	Browserify	Power User Home	uiStartup	2624	2051	4846	464	2745	4016
			load	1195	970	2712	252	1181	1628
			domContentLoaded	1195	969	2711	252	1181	1628
			domInteractive	127	33	627	130	108	468
			firstPaint	-	-	-	-	-	-
			backgroundConnect	115	34	1527	158	110	314
			firstReactRender	61	38	276	27	61	99
			getState	284	87	908	232	365	825
			initialActions	4	0	43	8	2	34
			loadScripts	1150	947	2520	205	1151	1532
			setupStore	156	8	935	184	150	569
			numNetworkReqs	100	59	246	60	79	239
	Webpack	Standard Home	uiStartup	1479	1265	1862	143	1564	1792
			load	1225	1065	1604	111	1302	1414
			domContentLoaded	1225	1065	1603	111	1301	1414
			domInteractive	55	27	139	31	76	117
			firstPaint	-	-	-	-	-	-
			backgroundConnect	45	17	154	25	45	107
			firstReactRender	27	20	83	9	27	37
			getState	14	6	151	17	13	40
			initialActions	1	0	2	0	2	2
			loadScripts	1196	1049	1538	102	1274	1388
			setupStore	17	5	256	30	14	45
			numNetworkReqs	12	5	73	17	7	63
	Webpack	Power User Home	uiStartup	3172	2157	5756	843	3408	5004
			load	1612	1203	3415	519	1708	3018
			domContentLoaded	1611	1203	3415	519	1708	3018
			domInteractive	135	31	1124	162	111	499
			firstPaint	-	-	-	-	-	-
			backgroundConnect	175	23	1210	216	163	426
			firstReactRender	70	44	232	31	70	152
			getState	262	70	1113	218	322	806
			initialActions	4	0	94	11	2	6
			loadScripts	1541	1176	3228	443	1677	2829
			setupStore	140	10	1133	186	154	606
			numNetworkReqs	101	62	251	61	79	243

📊 Page Load Benchmark Results

Current Commit:df0041f |Date: 11/28/2025

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

pageLoadTime-> current mean value: 1.03s (±56ms) 🟡 | historical mean value: 1.05s ⬇️ (historical data)
domContentLoaded-> current mean value: 722ms (±53ms) 🟢 | historical mean value: 728ms ⬇️ (historical data)
firstContentfulPaint-> current mean value: 76ms (±10ms) 🟢 | historical mean value: 78ms ⬇️ (historical data)

📈 Detailed Results

Metric	Mean	Std Dev	Min	Max	P95	P99
pageLoadTime	1.03s	56ms	1.01s	1.33s	1.07s	1.33s
domContentLoaded	722ms	53ms	699ms	1.02s	752ms	1.02s
firstPaint	76ms	10ms	60ms	160ms	88ms	160ms
firstContentfulPaint	76ms	10ms	60ms	160ms	88ms	160ms
largestContentfulPaint	0ms	0ms	0ms	0ms	0ms	0ms

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 1.21 KiB (0.03%)
ui: 11.61 KiB (0.15%)
common: 9.58 KiB (0.11%)

MajorLiftand others added4 commits

November 28, 2025 16:42

Bumpeslint-plugin-react-hooks from^5.2.0 to^6.1.1

dc993b9

Update LavaMoat policies

c36fe5f

Manually configure lint entries provided by `plugin:react-hooks/recom…

07de5fa

…mended`

Bumpeslint-plugin-react-hooks from^6.1.1 to^7.0.1

402c831

MajorLift force-pushed thejongsun/chore/lint/bump-eslint-plugin-react-hooks-to-v7 branch fromdf0041f to402c831Compare

November 28, 2025 21:43

Copy link

ContributorAuthor