Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

enable analyze union / stop collect field when object marked SuppressSourceGeneration#2106

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
neuecc merged 4 commits intomasterfromenable-union-analyzer
Dec 26, 2024

Conversation

@neuecc
Copy link
Member

@neueccneuecc commentedDec 25, 2024
edited
Loading

I modified the code so that Union-related Analyzers, which had been terminated, would now perform analysis.
As for the bug, red underlines don't appear in the source code (I wonder what caused this - I feel like I've encountered this before but can't remember at all).
However, since errors are still displayed in the error list when building, I suppose this is within acceptable limits.

Additionally, when SuppressSourceGeneration=true, I made it not parse the fields.
While there is a side effect that the Analyzer doesn't check all fields, I think it's fine to consider execution permission as almost equivalent.
Whether it's Visual Studio that's the problem, or if it's the v3 architecture that combines Source Generator and Analyzer - there are quite puzzling behaviors when it comes to error reporting.

@neueccneuecc changed the titleenable analyze unionenable analyze union / stop collect field when object marked SuppressSourceGenerationDec 25, 2024
@neuecc
Copy link
MemberAuthor

By the way, the current unit testing system for the Source Generator is terrible.
Its resistance to change is too low, which will become a major technical debt for future modifications.

@neueccneuecc merged commitfb8fac0 intomasterDec 26, 2024
3 checks passed
@neueccneuecc deleted the enable-union-analyzer branchDecember 26, 2024 09:02
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@neuecc

[8]ページ先頭

©2009-2025 Movatter.jp