Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork754
enable analyze union / stop collect field when object marked SuppressSourceGeneration#2106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
MemberAuthor
neuecc commentedDec 25, 2024
By the way, the current unit testing system for the Source Generator is terrible. |
fb8fac0 intomaster 3 checks passed
Uh oh!
There was an error while loading.Please reload this page.
This was referencedDec 2, 2025
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
I modified the code so that Union-related Analyzers, which had been terminated, would now perform analysis.
As for the bug, red underlines don't appear in the source code (I wonder what caused this - I feel like I've encountered this before but can't remember at all).
However, since errors are still displayed in the error list when building, I suppose this is within acceptable limits.
Additionally, when SuppressSourceGeneration=true, I made it not parse the fields.
While there is a side effect that the Analyzer doesn't check all fields, I think it's fine to consider execution permission as almost equivalent.
Whether it's Visual Studio that's the problem, or if it's the v3 architecture that combines Source Generator and Analyzer - there are quite puzzling behaviors when it comes to error reporting.