Thanks, I'll check soon.

Thanks for reviewing. And ya, sorry about the size of the PR. I too am relying on tests overall to know that we're moving forward. And yes, we surely need to add more tests for better coverage as we go.

Regarding your generics question, I still like my proposal that you linked to. I don't think it's fully implemented yet. Generics is a huge space for this and I think it'll have to come incrementally.
But regarding the particular code snippets you shared, I don't understand why you would apply[MessagePackFormatter] attributes to a formatter type. Isn't that attribute meant to be applied to adata type in order to help a resolver find the formatter?

The current changes give users the impression that custom formatters are automatically included.

That's exactly right. The only case whereMessagePackFormatterAttribute is required after this change would be to bring in a formatter that is declared in someother assembly than the data type itself.

I understand. No worries.

I don't understand why you would apply[MessagePackFormatter] attributes to a formatter type.

Oh, sorry, I meant to provide the following example but omitted it.

[MessagePackObject]publicclassMyClass{[Key(0)][MessagePackFormatter(typeof(MyCustomFormatter<int>))]publicintMyProperty{get;set;}}publicclassMyCustomFormatter<T>:IMessagePackFormatter<T>{//...snip}

I think that example will do the right thing. Specifically, the 'open generic' formatter will get into the resolver as an open generic. Then specific closed generic types that are statically discoverable also make it into the resolver specifically, thus avoidingActivator.CreateInstance and allowing AOT compilers to know which formatter closed generic types to compile native code for.