Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork754
Improved UnityShims for better code sharing#1585
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
AArnott merged 2 commits intoMessagePack-CSharp:developfromScormave:dev/unity-shims-improvementsJan 25, 2024
Merged
Improved UnityShims for better code sharing#1585
AArnott merged 2 commits intoMessagePack-CSharp:developfromScormave:dev/unity-shims-improvementsJan 25, 2024
+196 −14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Collaborator
AArnott commentedApr 6, 2023
Thanks. It looks good, but I am not familiar with unity so I'm going to ask@neuecc to review. |
Collaborator
AArnott commentedJan 22, 2024
@neuecc ping on this. |
neuecc approved these changesJan 24, 2024
Member
neuecc left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
sorry for delayed response.
It seems good.
Collaborator
AArnott commentedJan 25, 2024
/azp run |
| Azure Pipelines successfully started running 1 pipeline(s). |
This was referencedDec 2, 2025
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sometimes it is necessary to share code between client and server, including Unity types like Vector2, Vector3 etc...
For better code sharing it is worth to have Unity-like properties and methods in UnityShims.