- Notifications
You must be signed in to change notification settings - Fork1
refactor(bigquery): update code samples and move to own sample file#98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:master
Are you sure you want to change the base?
Uh oh!
There was an error while loading.Please reload this page.
Conversation
IlyaFaer commentedJan 20, 2020
Whoa, it's too many changes. We agreed with Tim Swast, that we'll be pushing the samples in portions: five samples per PR |
HemangChothani commentedJan 20, 2020
@IlyaFaer ok sure i will do that. |
mf2199 left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Looks good overall. Are you doing this by hand or using a script?
| # limitations under the License. | ||
| import os | ||
| from google.cloud import bigquery |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Either, add a blank line here or remove blank lines elsewhere to maintain formatting consistency.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
@mf2199 By hand as need to change few things and also have to add few assertion
Uh oh!
There was an error while loading.Please reload this page.
Towards [8989]
List of changes:
New samples: