- Notifications
You must be signed in to change notification settings - Fork1
fix(storage): fix documentation of max_result parameter in list_blob#95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:master
Are you sure you want to change the base?
Uh oh!
There was an error while loading.Please reload this page.
Conversation
| (Optional) The maximum number of blobs in each page of results | ||
| from this request. Non-positive values are ignored. Defaults to | ||
| a sensible value set by the API. | ||
| (Optional) The maximum number of blobs to return. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I'd rather minimize the changes:
(Optional) The maximum total number of blobs in results from this request. Non-positive values are ignored. Defaults to a sensible value set by the API.The last sentence can possibly be removed if the default value does not exist.
HemangChothaniJan 8, 2020 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I don't think "Non-positive values are ignored." is actually true from the implementation.None is ignored/header is not set so default applies, and 0 and negative numbers are equivalent and will result in an empty iterator.
848b1bf to1c0ab69Comparebz2 commentedJan 8, 2020
@HemangChothani Thanks for picking this up, changing the docs here should be sufficient to resolvehttps://github.com/googleapis/google-cloud-python/issues/10030 I think. |
This reverts commit1c0ab69.
Uh oh!
There was an error while loading.Please reload this page.
IPR 10030