Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Fix display for 0 dimensional arrays#1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
benesch merged 1 commit intoMaterializeInc:masterfromjkosh44:empty-array
Oct 14, 2022

Conversation

jkosh44
Copy link

No description provided.

}

if depth == dims.len(){
returnwrite!(fmt,"{}", data.next().unwrap());
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Ifdepth == dims.len() == 0 thendata.next().unwrap() would panic because there is no data in a 0 dimensional array.

Copy link

@beneschbenesch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Nice! LGTM. Can you also send upstream to sfackler?

@beneschbenesch merged commitf58d010 intoMaterializeInc:masterOct 14, 2022
@benesch
Copy link

Done as:rust-postgres#12.

jkosh44 reacted with hooray emoji

@jkosh44jkosh44 deleted the empty-array branchOctober 14, 2022 12:58
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@petrosaggpetrosaggAwaiting requested review from petrosagg

1 more reviewer

@beneschbeneschbenesch approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jkosh44@benesch

[8]ページ先頭

©2009-2025 Movatter.jp