Commitfbb6d25

authored

Merge pull request#29 from MammatusPHP/switch-section-to-enum

Switch section to enum

2 parentsf05fb8a +e490fbe commitfbb6d25Copy full SHA for fbb6d25

File tree

+21

-7

lines changed

+21

-7

lines changed

Lines changed: 2 additions & 2 deletions

Original file line number	Diff line number	Diff line change
@@ -27,9 +27,9 @@ the `add` method will be returned through the `get` method and passed directly t
`27`	`27`	```php
`28`	`28`	`$values = new Values(new Values\Registry(Values\ValuesFile::createFromFile('path/to/helm/chart/values.yaml'));`
`29`	`29`
`30`		`-$values->registry->add('secion', ['PHP_INT_SIZE' => PHP_INT_SIZE]);`
	`30`	`+$values->registry->add(Section::Deployment, ['PHP_INT_SIZE' => PHP_INT_SIZE]);`
`31`	`31`
`32`		`-$values->registry->get()); // Returns: ['secion' => ['PHP_INT_SIZE' => PHP_INT_SIZE]]`
	`32`	`+$values->registry->get()); // Returns: ['deployments' => ['PHP_INT_SIZE' => PHP_INT_SIZE]]`
`33`	`33`	```
`34`	`34`
`35`	`35`	`#License`

Lines changed: 11 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -0,0 +1,11 @@`
	`1`	`+<?php`
	`2`	`+`
	`3`	`+declare(strict_types=1);`
	`4`	`+`
	`5`	`+namespaceMammatus\Kubernetes\Events\Helm\Groups;`
	`6`	`+`
	`7`	`+enum Section:string`
	`8`	`+{`
	`9`	`+case CronJob ='cronjobs';`
	`10`	`+case Deployment ='deployments';`
	`11`	`+}`

Lines changed: 4 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -4,6 +4,8 @@`
`4`	`4`
`5`	`5`	`namespaceMammatus\Kubernetes\Events\Helm\Values;`
`6`	`6`
	`7`	`+useMammatus\Kubernetes\Events\Helm\Groups\Section;`
	`8`	`+`
`7`	`9`	`finalclass Registry`
`8`	`10`	`{`
`9`	`11`	`/** @var array<string, array<string\|int, mixed>> */`
`@@ -14,9 +16,9 @@ public function __construct(private readonly ValuesFile $valuesFile)`
`14`	`16`	`}`
`15`	`17`
`16`	`18`	`/** @param array<string\|int, mixed> $values */`
`17`		`-publicfunctionadd(string$section,array$values):void`
	`19`	`+publicfunctionadd(Section$section,array$values):void`
`18`	`20`	`{`
`19`		`-$this->values[$section] =$this->valuesFile->swapInValues($values);`
	`21`	`+$this->values[$section->value] =$this->valuesFile->swapInValues($values);`
`20`	`22`	`}`
`21`	`23`
`22`	`24`	`/** @return array<string, array<string\|int, mixed>> */`

Lines changed: 4 additions & 3 deletions

Original file line number	Diff line number	Diff line change
`@@ -4,6 +4,7 @@`
`4`	`4`
`5`	`5`	`namespaceMammatus\Tests\Kubernetes\Events\Helm;`
`6`	`6`
	`7`	`+useMammatus\Kubernetes\Events\Helm\Groups\Section;`
`7`	`8`	`useMammatus\Kubernetes\Events\Helm\Values;`
`8`	`9`	`usePHPUnit\Framework\Attributes\Test;`
`9`	`10`	`useWyriHaximus\TestUtilities\TestCase;`
`@@ -18,9 +19,9 @@ public function registry(): void`
`18`	`19`	`{`
`19`	`20`	`$values =newValues(newValues\Registry(Values\ValuesFile::createFromFile(__DIR__ .DIRECTORY_SEPARATOR .'values.yaml',__DIR__ .DIRECTORY_SEPARATOR .'values-secrets.yaml')));`
`20`	`21`
`21`		`-$values->registry->add('secion', ['PHP_INT_SIZE' =>PHP_INT_SIZE]);`
`22`		`-$values->registry->add('fromValues', ['key' =>'${VALUES:nested.value}','foo' =>'${VALUES:env.FOO}']);`
	`22`	`+$values->registry->add(Section::CronJob, ['PHP_INT_SIZE' =>PHP_INT_SIZE]);`
	`23`	`+$values->registry->add(Section::Deployment, ['key' =>'${VALUES:nested.value}','foo' =>'${VALUES:env.FOO}']);`
`23`	`24`
`24`		`-self::assertSame(['secion' => ['PHP_INT_SIZE' =>PHP_INT_SIZE],'fromValues' => ['key' =>'bier','foo' =>'bar']],$values->registry->get());`
	`25`	`+self::assertSame([Section::CronJob->value => ['PHP_INT_SIZE' =>PHP_INT_SIZE],Section::Deployment->value => ['key' =>'bier','foo' =>'bar']],$values->registry->get());`
`25`	`26`	`}`
`26`	`27`	`}`

Comments

(0)