- Notifications
You must be signed in to change notification settings - Fork435
Handle PROTOCOL_CANCELLED (state 3) in _dispatch_result.#1283
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Draft
mnbbrown wants to merge1 commit intoMagicStack:masterChoose a base branch
base:master
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Prior to this patch the state machine did not handle results arrivingafter cancellation. This add explicit support for that scenario bykeeping track of the state prior the cancellation(cancelled_from_state), and using cancelled_from_state when consuming theresults.The alternative option is just silently dropping the results (similar toPROTOCOL_TERMINATING).
Author
mnbbrown commentedOct 26, 2025
Upon reflection I'm not sure this is the best approach.. it would possibly leave a connection in a state that's unexpected by the client. Needs further thought. |
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
None yet
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
Prior to this patch the state machine did not handle results arriving
after cancellation. This add explicit support for that scenario by
keeping track of the state prior to cancellation
(cancelled_from_state), and using cancelled_from_state when consuming the
results.
The alternative option is just silently dropping the results (similar to
PROTOCOL_TERMINATING).
Would maybeclose#490