- Notifications
You must be signed in to change notification settings - Fork435
Makeprepare() not use named statements by default when cache is disabled#1245
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
…sabledWe allow disabling the statement cache to circumvent a proxy's inability tocope with them, however there are still some holes where the use of a namedstatement is attempted: `prepare()` with the default arguments, and`copy_in()`. Fix both so that the use of a named statement is dependentupon whether the prepared statement cache is enabled.Fixes:#1219Closes:#1218
5b14653 intomaster 41 checks passed
Uh oh!
There was an error while loading.Please reload this page.
elprans added a commit that referenced this pull requestNov 24, 2025
Enable Python 3.14 with experimental subinterpreter/freethreadingsupport.Improvements============* Add Python 3.14 support, experimental subinterpreter/freethreading support (#1279) (by@elprans in9e42642)* Avoid performing type introspection on known types (#1243) (by@elprans in5c9986c)* Make `prepare()` not use named statements by default when cache is disabled (#1245) (by@elprans in5b14653)* Implement connection service file functionality (#1223) (by@AndrewJackson2020 in1d63bb1)Fixes=====* Fix multi port connection string issue (#1222) (by@AndrewJackson2020 in01c0db7)* Avoid leaking connections if _can_use_connection fails (#1269) (by@yuliy-openai ine94302d)Other=====* Drop support for EOL Python 3.8 (#1281) (by@elprans in6c2c490)
Merged
1 task
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We allow disabling the statement cache to circumvent a proxy's inability to
cope with them, however there are still some holes where the use of a named
statement is attempted:
prepare()with the default arguments, andcopy_in(). Fix both so that the use of a named statement is dependentupon whether the prepared statement cache is enabled.
Fixes:#1219
Closes:#1218