NotificationsYou must be signed in to change notification settings
Fork463
Star6.8k

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

add a notifications helper class#971

Open

xaoseric wants to merge1 commit intoMacPass:master

base:master

Choose a base branch

fromXAOS-Interactive:impl-notifications

Open

add a notifications helper class#971

xaoseric wants to merge1 commit intoMacPass:masterfromXAOS-Interactive:impl-notifications

Conversation

Copy link

xaoseric commentedSep 1, 2019

This adds a notifications helper class, should help with implementing issue#951

add a notifications helper class

cfad37f

mstarke reviewed

Sep 1, 2019

View reviewed changes

Copy link

Member

mstarke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thank you for the PR but this is currently not mergeable for 0.7.x since the UserNotification framework requires 10.14 and the deploy target for MacPass ist still 10.10. This will be raised with 0.8 to 10.12 or even higher but the 0.7.x branch should stay compatible with 10.10. which requires to stick with the deprecated NSUserNotification. Another note - I'm hesitant to introduce .swift code since it requires to bundle the swift runtime AFAIK and I also do not have no plans to fully convert MacPass to swift any time soon. This might sound foolish but for now I'm more productive with Obj-C and keeping the code base manageable for me is of high value.