- Notifications
You must be signed in to change notification settings - Fork15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Add Nix flake support#370
base:master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Thanks for the very long contribution. I've used nix before but barely, I just used it as some package required it so I don't know how to test this but assume it works.
However I think this ought to also build (at least) MFEKmetadata, MFEKstroke, MFEKpathops, MFEKinit. They're all a lot simpler to build. Some functions willnot work if MFEKmetadata is not installed. MFEKinit is very useful for making initial .glif files.
If you do this then probably these files belong in a new repo, MFEK/flake.nix. I can create it for you and leave it empty if you want me to. |
Oh and last thought. MFEK's IPC uses |
I would suggest a flake in each of those other repositories, then depend on them from the flake in this repository. Having a "parking" repository just for a combined flake kind of defeats the purpose and expected usage. |
Oh, I see. Well, I still think a parking repository makes sense, as even though this is the org's most popular project, it's not the "root" module in any sense. You can use MFEKstroke / MFEKpathops / MFEKmetadata without it just fine. But perhaps that actually makes this easier for@jakeisnt. If he adds a flake to MFEKmetadata, and makes this rely on that, I'll consider that enough to merge this. (That's the only IPC-checked dependency at current.) |
Agree that the flake-per-repo approach is more reasonable, as it allows developers to make use of nix shell environments. On it! |
Thanks! Sorry for my ignorance of NixOS :-) If there's enough interest I'll make MFEK/flake.nix myself after merging this and the MFEKmetadata PR. |
Do you think that the idea of having an MFEK/flake.nix with all the binary tools isn't useful then? The best supported installation method, if you can even call it one, is basically that:
|
Marked as draft as blocked onMFEK/metadata#139 (comment) (see subsequent comment on potential fix). |
This helps anyone who uses
NixOSornixget started with a development environment seamlessly. If someone hasnixanddirenvinstalled, upon entering this repository they'll have a development environment with the exact versions of rust and all of the system packages necessary to build the repo.It:
glif-testcommand adhering to the suggestedcargo runcommand in the README for testing the packageglifpackage, which can then be pulled into other packagesI put this together to get glif to run on my end; merge if others would use, OK to close if not.