NotificationsYou must be signed in to change notification settings
Fork0
Star0

Commit1cf868e

committed

fix memoization issues

1 parenta80dae6 commit1cf868eCopy full SHA for 1cf868e

File tree

1 file changed

+16

-28

lines changed

client/packages/lowcoder/src/comps/generators
- uiCompBuilder.tsx

1 file changed

+16

-28

lines changed

`‎client/packages/lowcoder/src/comps/generators/uiCompBuilder.tsx‎`

Lines changed: 16 additions & 28 deletions

Original file line number	Diff line number	Diff line change
`@@ -384,14 +384,18 @@ const UIView = React.memo((props: {`
`384`	`384`	`]);`
`385`	`385`
`386`	`386`	`// render condition for modal and drawer as we are not getting compType here`
`387`		`-`
`388`		`-constuiCompRender=useMemo(()=>props.viewFn(childrenProps,comp.dispatch),[`
`389`		`-childrenProps,`
`390`		`-comp.dispatch`
`391`		`-]);`
`392`		`-`
`393`		`-constuiCompRenderWithWrapper=useMemo(()=>{`
	`387`	`+if(comp.children.hasOwnProperty('showMask')&&comp.children.hasOwnProperty('maskClosable')){`
`394`	`388`	`return(`
	`389`	`+<HidableViewhidden={childrenProps.hiddenasboolean}>`
	`390`	`+{props.viewFn(`
	`391`	`+childrenProps,`
	`392`	`+comp.dispatch`
	`393`	`+)}`
	`394`	`+</HidableView>`
	`395`	`+);`
	`396`	`+}`
	`397`	`+`
	`398`	`+return(`
`395`	`399`	`<div`
`396`	`400`	`ref={props.innerRef}`
`397`	`401`	`className={childrenProps.classNameasstring}`
`@@ -400,30 +404,14 @@ const UIView = React.memo((props: {`
`400`	`404`	`width:'100%',`
`401`	`405`	`height:'100%',`
`402`	`406`	`margin:'0px',`
`403`		`-padding:getPadding()`
	`407`	`+padding:getPadding(),`
`404`	`408`	`}}`
`405`	`409`	`>`
`406`		`-{uiCompRender}`
	`410`	`+<HidableViewhidden={childrenProps.hiddenasboolean}>`
	`411`	`+{props.viewFn(childrenProps,comp.dispatch)}`
	`412`	`+</HidableView>`
`407`	`413`	`</div>`
`408`		`-)},[`
`409`		`-uiCompRender,`
`410`		`-props.innerRef,`
`411`		`-childrenProps.className,`
`412`		`-childrenProps.dataTestId,`
`413`		`-getPadding,`
`414`		`-]);`
`415`		`-`
`416`		`-constrenderView=useMemo(()=>{`
`417`		`-if(`
`418`		`-comp.children.hasOwnProperty('showMask')`
`419`		`-&&comp.children.hasOwnProperty('maskClosable')`
`420`		`-){`
`421`		`-returnuiCompRender;`
`422`		`-}`
`423`		`-returnuiCompRenderWithWrapper;`
`424`		`-},[comp.children]);`
`425`		`-`
`426`		`-returnrenderView;`
	`414`	`+);`
`427`	`415`	`},(prevProps,nextProps)=>{`
`428`	`416`	`returnisEqual(prevProps,nextProps);`
`429`	`417`	`});`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit1cf868e

File tree

1 file changed

1 file changed

`‎client/packages/lowcoder/src/comps/generators/uiCompBuilder.tsx‎`

0 commit comments