Commit9da2673

authored

Merge pull requestlowcoder-org#648 from raheeliftikhar5/sdk-rerendering-fix

Fix apps re-rendering issue with SDK

2 parents9d0cab1 +d19c210 commit9da2673Copy full SHA for 9da2673

File tree

+10

-7

lines changed

+10

-7

lines changed

Lines changed: 4 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -1,5 +1,6 @@`
`1`	`1`	`import{useRef}from"react";`
`2`	`2`	`importReactDOM,{flushSync}from"react-dom";`
	`3`	`+import{createRoot}from"react-dom/client";`
`3`	`4`	`import{AppViewInstance,bootstrapAppAt,LowcoderAppView}from"./src/index";`
`4`	`5`
`5`	`6`	`consturl=newURL(location.href);`
`@@ -70,7 +71,9 @@ async function bootstrap() {`
`70`	`71`	`});`
`71`	`72`
`72`	`73`	`// React`
`73`		`-ReactDOM.render(<ReactDemoApp/>,document.querySelector("#app2"));`
	`74`	`+constcontainer=document.querySelector("#app2");`
	`75`	`+constroot=createRoot(container!);`
	`76`	`+root.render(<ReactDemoApp/>);`
`74`	`77`	`}`
`75`	`78`
`76`	`79`	`bootstrap();`

Lines changed: 1 addition & 1 deletion

Lines changed: 3 additions & 4 deletions

Original file line number	Diff line number	Diff line change
`@@ -4,7 +4,7 @@ import { RootComp } from "comps/comps/rootComp";`
`4`	`4`	`import{setGlobalSettings}from"comps/utils/globalSettings";`
`5`	`5`	`import{sdkConfig}from"constants/sdkConfig";`
`6`	`6`	`import_from"lodash";`
`7`		`-import{createRoot}from"react-dom/client";`
	`7`	`+import{Root}from"react-dom/client";`
`8`	`8`	`import{StyleSheetManager}from"styled-components";`
`9`	`9`	`import{ModuleDSL,ModuleDSLIoInput}from"types/dsl";`
`10`	`10`	`import{AppView}from"./AppView";`
`@@ -40,7 +40,7 @@ export class AppViewInstance<I = any, O = any> {`
`40`	`40`	`webUrl:"https://app.lowcoder.cloud",`
`41`	`41`	`};`
`42`	`42`
`43`		`-constructor(privateappId:string,privatenode:Element,options:AppViewInstanceOptions={}){`
	`43`	`+constructor(privateappId:string,privatenode:Element,privateroot:Root,options:AppViewInstanceOptions={}){`
`44`	`44`	`Object.assign(this.options,options);`
`45`	`45`	`if(this.options.baseUrl){`
`46`	`46`	`sdkConfig.baseURL=this.options.baseUrl;`
`@@ -137,8 +137,7 @@ export class AppViewInstance<I = any, O = any> {`
`137`	`137`
`138`	`138`	`privateasyncrender(){`
`139`	`139`	`constdata=awaitthis.dataPromise;`
`140`		`-constroot=createRoot(this.node);`
`141`		`-root.render(`
	`140`	`+this.root.render(`
`142`	`141`	`<StyleSheetManagertarget={this.nodeasHTMLElement}>`
`143`	`142`	`<AppView`
`144`	`143`	`appId={this.appId}`

Lines changed: 2 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -1,5 +1,6 @@`
`1`	`1`	`import{loadComps}from"comps";`
`2`	`2`	`import{AppViewInstance,AppViewInstanceOptions}from"./AppViewInstance";`
	`3`	`+import{createRoot}from"react-dom/client";`
`3`	`4`
`4`	`5`	`loadComps();`
`5`	`6`
`@@ -12,5 +13,5 @@ export async function bootstrapAppAt<I>(`
`12`	`13`	`console.error("node must be not null.");`
`13`	`14`	`return;`
`14`	`15`	`}`
`15`		`-returnnewAppViewInstance(appId,node,options);`
	`16`	`+returnnewAppViewInstance(appId,node,createRoot(node),options);`
`16`	`17`	`}`

Comments

(0)