Codecov Report

Attention: Patch coverage is71.42857% with2 lines in your changes missing coverage. Please review.

Project coverage is 88.09%. Comparing base(d70346b) to head(860950d).
Report is 102 commits behind head on master.

@@             Coverage Diff              @@##             master     #266      +/-   ##============================================- Coverage     88.24%   88.09%   -0.15%- Complexity      317      318       +1============================================  Files            50       50                Lines          1531     1537       +6       Branches         86       87       +1     ============================================+ Hits           1351     1354       +3- Misses          143      144       +1- Partials         37       39       +2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report?Share it here.

I will add tests for this.

what is the spring boot version you are running with?

what is the spring boot version you are running with?

@jvmlet 2.5.6

@jvmlet any recommendations on how I can get the code coverage to pass? I checkedhttps://app.codecov.io/gh/LogNet/grpc-spring-boot-starter/compare/266/changes and it seems to have no changes and I also added tests to ensure the bean loading works correctly but it complains about +0.15% coverage decrease.

I did some digging why that newly added code is not called during the integration tests. Here is my summary. Feedback welcome on how we could change these tests to reproduce this behaviour, as I am currently unable to determine what specifically is causing this behaviour to occur.

Scenario 1: AnnotatedGenericBeanDefinition

This is the current logic within the unit tests of this Spring Boot starter. Setting up the bean like this:

...will internally create anAnnotatedGenericBeanDefinition and set it on the internalbeanFactoryMap within thebeanFactory. As a result,beanDefinition.getBeanClassName() is not null.

Scenario 2: ConfigurationClassBeanDefinitionReader$ConfigurationClassBeanDefinition

Within our codebase, we use a custom Spring Boot starter to define a custom advice like so:

@BeanpublicGrpcExceptionAdvicegrpcExceptionAdvice() {returnnewGrpcExceptionAdvice(); }

which itself looks like this:

@GRpcServiceAdvicepublicclassGrpcExceptionAdvice {/* exception handlers go here*/}

This is literally the same setup, however, for some reason it is using a different bean definition wherebeanDefinition.getBeanClassName() returnsnull and instead the class name can be obtained from the internalMethodMetadata on theAnnotatedBeanDefinition.

Question time!

How can I change the tests within this Spring Boot starter to replicateScenario 2?

See behavior difference if you define the inner advice class as static/non-static