- Notifications
You must be signed in to change notification settings - Fork1.4k
Raise error if disk is full before downloading weights#1903
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:main
Are you sure you want to change the base?
Uh oh!
There was an error while loading.Please reload this page.
Conversation
Uh oh!
There was an error while loading.Please reload this page.
Andrei-Aksionov commentedJan 9, 2025
Thanks for the PR 🚀 But there is one nuance 😊 |
Thanks!Co-authored-by: Andrei-Aksionov <58434077+Andrei-Aksionov@users.noreply.github.com>
rasbt commentedJan 9, 2025
Thanks, that's great and important point! |
rasbt commentedJan 12, 2025
RE CI failures: I actually now what happened here: the |
rasbt commentedJan 14, 2025
@Andrei-Aksionov RoPE tests should be fixed now for the latest transformer release and if tests pass on CI, this should be ready to merge. |
rasbt commentedJan 14, 2025
Ok there seem to be other issues now with the Phi model. Also unrelated to this PR. Maybe microsoft changed something. Or the transformers library changed something. |
Andrei-Aksionov commentedJan 14, 2025
Probably. |
Raises an error if a user attempts to download model weights that would exceed the current available free disk space. If this is run in a Studio, it additionally prompts the user to switch to a different Studio with more disk space.
This is a minor but important point as someone can easily shoot themselves in the foot by downloading things that exceed the available storage, because once it's full, the system may go in a weird state that doesn't allow deleting and restoring things.
Fixes#1841