Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Raise error if disk is full before downloading weights#1903

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Draft
rasbt wants to merge8 commits intomain
base:main
Choose a base branch
Loading
fromdisk-full-message

Conversation

@rasbt
Copy link
Contributor

Raises an error if a user attempts to download model weights that would exceed the current available free disk space. If this is run in a Studio, it additionally prompts the user to switch to a different Studio with more disk space.

This is a minor but important point as someone can easily shoot themselves in the foot by downloading things that exceed the available storage, because once it's full, the system may go in a weird state that doesn't allow deleting and restoring things.

Fixes#1841

@Andrei-Aksionov
Copy link
Contributor

Thanks for the PR 🚀

But there is one nuance 😊
We need to check for free disk space that is at least 2x of the model weight's size.
The code first downloads weights from HF and then converts to lit format -lit_model.pth.
Even if we change the code to delete HF weights right after the conversion, then still at the same time two sets of weights will exist (during conversion, before the deletion).

Thanks!Co-authored-by: Andrei-Aksionov <58434077+Andrei-Aksionov@users.noreply.github.com>
@rasbt
Copy link
ContributorAuthor

But there is one nuance 😊
We need to check for free disk space that is at least 2x of the model weight's size.
The code first downloads weights from HF and then converts to lit format - lit_model.pth.
Even if we change the code to delete HF weights right after the conversion, then still at the same time two sets of weights will exist (during conversion, before the deletion).

Thanks, that's great and important point!

@rasbt
Copy link
ContributorAuthor

RE CI failures: I actually now what happened here: thetransformer package had a new release a few days back and this caused some issues with the rope unit tests (unrelated to this PR). I know how to fix and can take a look the next couple of days.

Andrei-Aksionov reacted with heart emoji

@rasbt
Copy link
ContributorAuthor

@Andrei-Aksionov RoPE tests should be fixed now for the latest transformer release and if tests pass on CI, this should be ready to merge.

@rasbt
Copy link
ContributorAuthor

Ok there seem to be other issues now with the Phi model. Also unrelated to this PR. Maybe microsoft changed something. Or the transformers library changed something.

@Andrei-Aksionov
Copy link
Contributor

Probably.
I think these issues need to be resolved in separate PRs.
Then merged to this one.

@t-vit-vi self-requested a review as acode ownerJanuary 30, 2025 08:17
@BordaBorda added the bugSomething isn't working labelMar 12, 2025
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@lantigalantigaAwaiting requested review from lantigalantiga is a code owner

@t-vit-viAwaiting requested review from t-vit-vi is a code owner

@lianakolevalianakolevaAwaiting requested review from lianakolevalianakoleva will be requested when the pull request is marked ready for reviewlianakoleva is a code owner

@KaelanDtKaelanDtAwaiting requested review from KaelanDtKaelanDt will be requested when the pull request is marked ready for reviewKaelanDt is a code owner

@k223kimk223kimAwaiting requested review from k223kimk223kim will be requested when the pull request is marked ready for reviewk223kim is a code owner

@andylandandylandAwaiting requested review from andylandandyland will be requested when the pull request is marked ready for reviewandyland is a code owner

1 more reviewer

@Andrei-AksionovAndrei-AksionovAndrei-Aksionov approved these changes

Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

bugSomething isn't workingwaiting on author

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Show a warning if there is no enough space to download weights

3 participants

@rasbt@Andrei-Aksionov@Borda

[8]ページ先頭

©2009-2025 Movatter.jp