Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

parseDescription using regex#752

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
csalg wants to merge5 commits intoLeetCode-OpenSource:master
base:master
Choose a base branch
Loading
fromcsalg:parseDescription-using-regex

Conversation

csalg
Copy link

There are several issues open regardingparseDescription breaking the whole extension, e.g.#749,#715

The problem seems to be thatvscode-leetcode-cli sometimes prepends a few lines on top of the output, which breaks theparseDescription method.

This PR addresses this issue in two ways:

  1. It uses regex to parse the output instead of breaking the output into lines and hardcoding in which line each property should be. This solves tthe issue of the output having lines prepended.
  2. It assumes that the string can be empty or formatting might change and will not break under those circumstances, instead providing some defaults.

@csalg
Copy link
Author

Additionally, I wrote two regression tests but I am not sure what to do with them. Is there a different repo with tests?

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

1 participant
@csalg

[8]ページ先頭

©2009-2025 Movatter.jp