- Notifications
You must be signed in to change notification settings - Fork668
Get slug from problem list for a new option of filename in English.#725
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:master
Are you sure you want to change the base?
Uh oh!
There was an error while loading.Please reload this page.
Changes fromall commits
File filter
Filter by extension
Conversations
Uh oh!
There was an error while loading.Please reload this page.
Jump to
Uh oh!
There was an error while loading.Please reload this page.
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -234,6 +234,8 @@ async function resolveRelativePath(relativePath: string, node: IProblem, selecte | ||
return node.id; | ||
case "name": | ||
return node.name; | ||
case "slug": | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others.Learn more. I guess we need to think for a better name of this new placeholder, There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others.Learn more. You got me... There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others.Learn more. I found thisWhat is a “slug” in Django:it is created from the title by down-casing all letters, and replacing spaces by hyphens There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others.Learn more. Hmm, I like the idea to provide I think (maybe) a better solution here is having a setting to specify whether to use translated name as the file name, and then, we can provide different style option to the user(kebab, snake, pascal, ...)? | ||
return node.slug; | ||
case "camelcasename": | ||
return _.camelCase(node.name); | ||
case "pascalcasename": | ||