- Notifications
You must be signed in to change notification settings - Fork668
Get slug from problem list for a new option of filename in English.#725
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:master
Are you sure you want to change the base?
Uh oh!
There was an error while loading.Please reload this page.
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
LGTM
| @@ -234,6 +234,8 @@ async function resolveRelativePath(relativePath: string, node: IProblem, selecte | |||
| return node.id; | |||
| case "name": | |||
| return node.name; | |||
| case "slug": | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I guess we need to think for a better name of this new placeholder,slug is not straightforward to me at least...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
You got me...
I don't know what slug means in problem list.
Maybe name_en？
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I found thisWhat is a “slug” in Django:it is created from the title by down-casing all letters, and replacing spaces by hyphens-.
It's not easy to find a word to replace "slug", "short-label"?"kebab-case-title"? or just "slug"?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Hmm, I like the idea to provideEnglish name as the file name. But there is one problem: people might ask 'Ok, we have the slug styled name, so what about the camel case/pascal case/snake case'?
I think (maybe) a better solution here is having a setting to specify whether to use translated name as the file name, and then, we can provide different style option to the user(kebab, snake, pascal, ...)?
Uh oh!
There was an error while loading.Please reload this page.
Depends onProvide an English filename when using Endpoint Translation
This might be a better way than#724